Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Switch from printf to panic. These messages were notorious for being 

unreadable, and at least a clean panic allows the user to inspect the
system via DDB. Also simplify the output, EAX gets overwritten with
the error code so it indicates nothing meaningful.
This commit is contained in:
maxv 2019-08-21 16:35:10 +00:00
parent d9ec4c1e4c
commit 4595fe3dd9
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/arch/amd64/amd64/locore.S
View File

@ -1,4 +1,4 @@
/* $NetBSD: locore.S,v 1.185 2019/05/18 13:32:12 maxv Exp $ */
/* $NetBSD: locore.S,v 1.186 2019/08/21 16:35:10 maxv Exp $ */
/*
* Copyright-o-rama!
@ -1322,19 +1322,11 @@ ENTRY(handle_syscall)
jmp syscall_sysret
#ifdef DIAGNOSTIC
/* Report SPL error */
.Lspl_error:
movabsq $4f,%rdi
movl TF_RAX(%rsp),%esi
movl TF_RDI(%rsp),%edx
movl %ebx,%ecx
movl CPUVAR(ILEVEL),%r8d
xorq %rax,%rax
call _C_LABEL(printf)
movl $IPL_NONE,%edi
call _C_LABEL(spllower)
jmp .Lsyscall_checkast
4: .asciz "WARNING: SPL NOT LOWERED ON SYSCALL %d %d EXIT %x %x\n"
movl CPUVAR(ILEVEL),%esi
call _C_LABEL(panic)
4: .asciz "spl not lowered on syscall, ilevel=%x"
#endif
/* AST pending or pmap load needed */