Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

open the tty with O_RDWR|O_NONBLOCK. it seems valid to ask for

Browse Source 
write permission when we're setting flags, and ucom(4) has an
existing workaround for a bug when O_RDWR is not used, and thus
ttyflags would not work for ucom devices.
This commit is contained in:
mrg 2014-05-04 20:43:30 +00:00
parent 126d985871
commit 424f4c982d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sbin/ttyflags/ttyflags.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: ttyflags.c,v 1.18 2011/08/27 18:58:51 joerg Exp $ */
/* $NetBSD: ttyflags.c,v 1.19 2014/05/04 20:43:30 mrg Exp $ */
/*
* Copyright (c) 1994 Christopher G. Demetriou
@ -41,7 +41,7 @@ __COPYRIGHT("@(#) Copyright (c) 1994\
#endif /* not lint */
#ifndef lint
__RCSID("$NetBSD: ttyflags.c,v 1.18 2011/08/27 18:58:51 joerg Exp $");
__RCSID("$NetBSD: ttyflags.c,v 1.19 2014/05/04 20:43:30 mrg Exp $");
#endif /* not lint */
#include <sys/types.h>
@ -214,7 +214,7 @@ change_ttyflags(struct ttyent *tep)
return (0);
/* Open the device NON-BLOCKING, set the flags, and close it. */
if ((fd = open(path, O_RDONLY | O_NONBLOCK, 0)) == -1) {
if ((fd = open(path, O_RDWR | O_NONBLOCK, 0)) == -1) {
if (!(errno == ENXIO ||
(errno == ENOENT && (st & TTY_ON) == 0)))
rval = 1;