Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Duh... check that malloc() hasn't returned a NULL *before* we zero the buffer,

Browse Source 
not after. Pointed out by Michael Graff.
This commit is contained in:
oster 1999-01-14 20:29:38 +00:00
parent a6f7b8ff0e
commit 4128f9df1e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/raidframe/rf_diskqueue.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: rf_diskqueue.c,v 1.2 1998/12/03 14:58:24 oster Exp $ */
/* $NetBSD: rf_diskqueue.c,v 1.3 1999/01/14 20:29:38 oster Exp $ */
/*
* Copyright (c) 1995 Carnegie-Mellon University.
* All rights reserved.
@ -351,7 +351,6 @@ static int init_dqd(dqd)
#ifdef __NetBSD__
/* XXX not sure if the following malloc is appropriate... probably not quite... */
dqd->bp = (struct buf *) malloc( sizeof(struct buf), M_DEVBUF, M_NOWAIT);
memset(dqd->bp,0,sizeof(struct buf)); /* if you don't do it, nobody else will.. */
/* XXX */
/* printf("NEED TO IMPLEMENT THIS BETTER!\n"); */
#else
@ -360,6 +359,9 @@ static int init_dqd(dqd)
if (dqd->bp == NULL) {
return(ENOMEM);
}
#ifdef __NetBSD__
memset(dqd->bp,0,sizeof(struct buf)); /* if you don't do it, nobody else will.. */
#endif
#endif /* KERNEL */
return(0);
}