Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

From Anon Ymous: 

The problem is that mime_decode_close() closes all files registered
after mip->mi_pipe_end and this is getting set in mime_sendmessage()
after a fflush().

When you print a large number of messages fflush() blocks and prevents
mip->mi_pipe_end from getting set before the SIGPIPE comes in and
jumps to the close block that calls mime_decode_close().  As a result,
mime_decode_close() was closing all the registered files including
obuf (mi_pipe_end was NULL).
This commit is contained in:
christos 2006-11-01 16:42:27 +00:00
parent ced98add61
commit 3bf60b1367
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
usr.bin/mail/mime_decode.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: mime_decode.c,v 1.2 2006/10/31 20:07:32 christos Exp $ */
/* $NetBSD: mime_decode.c,v 1.3 2006/11/01 16:42:27 christos Exp $ */
/*-
* Copyright (c) 2006 The NetBSD Foundation, Inc.
@ -41,7 +41,7 @@
#include <sys/cdefs.h>
#ifndef __lint__
__RCSID("$NetBSD: mime_decode.c,v 1.2 2006/10/31 20:07:32 christos Exp $");
__RCSID("$NetBSD: mime_decode.c,v 1.3 2006/11/01 16:42:27 christos Exp $");
#endif /* not __lint__ */
#include <assert.h>
@ -702,14 +702,18 @@ mime_sendmessage(struct message *mp, FILE *obuf, struct ignoretab *doign,
if (mip == NULL)
return sendmessage(mp, obuf, doign ? ignore : 0, prefix, NULL);
(void)fflush(obuf); /* Be safe and flush! XXX - necessary? */
/*
* Set these early so pipe_end() and mime_decode_close() work!
* XXX - Do this before anything that can block, like
* fflush()! Shouldn't we move these settings to
* mime_decode_open() to avoid a race condition?
* Especially, mip->mi_pipe_end?
*/
mip->mi_fo = obuf;
mip->mi_pipe_end = last_registered_file(0);
(void)fflush(obuf); /* Be safe and flush! XXX - necessary? */
/*
* Handle the prefix as a pipe stage so it doesn't get seen by
* any decoding or hooks.