Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary checks of IFF_ALLMULTI 

IFF_ALLMULTI is changed by only driver itself, so we don't need to check its
change on ec_ifflags_cb.

This is part of PR kern/54189. NFCI.
This commit is contained in:
ozaki-r 2019-05-14 09:43:55 +00:00
parent 863b2b98a5
commit 3adce096d0
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/pci/if_wm.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: if_wm.c,v 1.634 2019/04/24 11:18:20 msaitoh Exp $ */
/* $NetBSD: if_wm.c,v 1.635 2019/05/14 09:43:55 ozaki-r Exp $ */
/*
* Copyright (c) 2001, 2002, 2003, 2004 Wasabi Systems, Inc.
@ -82,7 +82,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.634 2019/04/24 11:18:20 msaitoh Exp $");
__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.635 2019/05/14 09:43:55 ozaki-r Exp $");
#ifdef _KERNEL_OPT
#include "opt_net_mpsafe.h"
@ -3319,7 +3319,7 @@ wm_ifflags_cb(struct ethercom *ec)
}
/* iff related updates */
if ((iffchange & (IFF_PROMISC | IFF_ALLMULTI)) != 0)
if ((iffchange & IFF_PROMISC) != 0)
wm_set_filter(sc);
wm_set_vlan(sc);

4
sys/dev/pci/ixgbe/ixgbe.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: ixgbe.c,v 1.181 2019/05/13 05:04:17 msaitoh Exp $ */
/* $NetBSD: ixgbe.c,v 1.182 2019/05/14 09:43:55 ozaki-r Exp $ */
/******************************************************************************
@ -6163,7 +6163,7 @@ ixgbe_ifflags_cb(struct ethercom *ec)
if ((change & ~(IFF_CANTCHANGE | IFF_DEBUG)) != 0)
rc = ENETRESET;
else if ((change & (IFF_PROMISC | IFF_ALLMULTI)) != 0)
else if ((change & IFF_PROMISC) != 0)
ixgbe_set_promisc(adapter);
/* Set up VLAN support and filter */