Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Redo dk_start(). If di->di_diskstart() runs synchronous its biodone() will

Browse Source 
call dk_start() via dk_iodone() before the buffer gets removed from queue.

Approved by: Roland Dowdeswell <elric@netbsd.org>

Fixes PR #25240
This commit is contained in:
hannken 2004-04-19 16:04:07 +00:00
parent 3097bbf440
commit 3a7080244e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/dksubr.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: dksubr.c,v 1.11 2004/03/27 23:23:06 elric Exp $ */ /* $NetBSD: dksubr.c,v 1.12 2004/04/19 16:04:07 hannken Exp $ */
/*- /*-
* Copyright (c) 1996, 1997, 1998, 1999, 2002 The NetBSD Foundation, Inc. * Copyright (c) 1996, 1997, 1998, 1999, 2002 The NetBSD Foundation, Inc.
@ -37,7 +37,7 @@
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: dksubr.c,v 1.11 2004/03/27 23:23:06 elric Exp $"); __KERNEL_RCSID(0, "$NetBSD: dksubr.c,v 1.12 2004/04/19 16:04:07 hannken Exp $");
#include <sys/param.h> #include <sys/param.h>
#include <sys/systm.h> #include <sys/systm.h>
@ -221,11 +221,11 @@ dk_start(struct dk_intf *di, struct dk_softc *dksc)
DPRINTF_FOLLOW(("dk_start(%s, %p)\n", di->di_dkname, dksc)); DPRINTF_FOLLOW(("dk_start(%s, %p)\n", di->di_dkname, dksc));
/* Process the work queue */ /* Process the work queue */
while ((bp = BUFQ_PEEK(&dksc->sc_bufq)) != NULL) { while ((bp = BUFQ_GET(&dksc->sc_bufq)) != NULL) {
if (di->di_diskstart(dksc, bp) != -1) if (di->di_diskstart(dksc, bp) != 0) {
(void) BUFQ_GET(&dksc->sc_bufq); BUFQ_PUT(&dksc->sc_bufq, bp);
else
break; break;
}
} }
} }