Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

specfs: Delete bogus comment about .d_open/.d_close at same time. 

Annoying as it is that .d_open and .d_close can run at the same time,
it is also necessary for tty semantics, where open can block
indefinitely, and it is the responsibility of close (called via
revoke) necessary to interrupt it.
This commit is contained in:
riastradh 2022-03-28 12:35:08 +00:00
parent c466e4b35b
commit 39e7464227
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/miscfs/specfs/spec_vnops.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: spec_vnops.c,v 1.190 2022/03/28 12:34:59 riastradh Exp $ */ /* $NetBSD: spec_vnops.c,v 1.191 2022/03/28 12:35:08 riastradh Exp $ */
/*- /*-
* Copyright (c) 2008 The NetBSD Foundation, Inc. * Copyright (c) 2008 The NetBSD Foundation, Inc.
@ -58,7 +58,7 @@
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.190 2022/03/28 12:34:59 riastradh Exp $"); __KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.191 2022/03/28 12:35:08 riastradh Exp $");
#include <sys/param.h> #include <sys/param.h>
#include <sys/proc.h> #include <sys/proc.h>
@ -557,12 +557,6 @@ spec_open(void *v)
* But first check whether it has been revoked -- if so, we * But first check whether it has been revoked -- if so, we
* can't acquire more open references and we must fail * can't acquire more open references and we must fail
* immediately with EBADF. * immediately with EBADF.
*
* XXX This races with revoke: once we release the vnode lock,
* the vnode may be revoked, and the .d_close callback run, at
* the same time as we're calling .d_open here. Drivers
* shouldn't have to contemplate this scenario; .d_open and
* .d_close should be prevented from running concurrently.
*/ */
switch (vp->v_type) { switch (vp->v_type) {
case VCHR: case VCHR: