Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sdiff: fix undefined behavior for ctype functions 

lint says: warning: argument to 'function from <ctype.h>' must be cast
to 'unsigned char', not to 'int' [342]
This commit is contained in:
rillig 2021-08-27 17:38:57 +00:00
parent 3b6b08b599
commit 3791d282ca
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
usr.bin/sdiff/sdiff.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: sdiff.c,v 1.2 2009/04/13 07:19:55 lukem Exp $ */ /* $NetBSD: sdiff.c,v 1.3 2021/08/27 17:38:57 rillig Exp $ */
/* $OpenBSD: sdiff.c,v 1.20 2006/09/19 05:52:23 otto Exp $ */ /* $OpenBSD: sdiff.c,v 1.20 2006/09/19 05:52:23 otto Exp $ */
/* /*
@ -423,7 +423,7 @@ prompt(const char *s1, const char *s2)
const char *p; const char *p;
/* Skip leading whitespace. */ /* Skip leading whitespace. */
for (p = cmd; isspace((int)(*p)); ++p) for (p = cmd; isspace((unsigned char)(*p)); ++p)
; ;
switch (*p) { switch (*p) {
@ -579,7 +579,7 @@ parsecmd(FILE *diffpipe, FILE *file1, FILE *file2)
p = line; p = line;
/* Go to character after line number. */ /* Go to character after line number. */
while (isdigit((int)(*p))) while (isdigit((unsigned char)(*p)))
++p; ++p;
c = *p; c = *p;
*p++ = 0; *p++ = 0;
@ -592,7 +592,7 @@ parsecmd(FILE *diffpipe, FILE *file1, FILE *file2)
q = p; q = p;
/* Go to character after file2end. */ /* Go to character after file2end. */
while (isdigit((int)(*p))) while (isdigit((unsigned char)(*p)))
++p; ++p;
c = *p; c = *p;
*p++ = 0; *p++ = 0;
@ -612,7 +612,7 @@ parsecmd(FILE *diffpipe, FILE *file1, FILE *file2)
q = p; q = p;
/* Go to character after line number. */ /* Go to character after line number. */
while (isdigit((int)(*p))) while (isdigit((unsigned char)(*p)))
++p; ++p;
c = *p; c = *p;
*p++ = 0; *p++ = 0;