Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Goto considered harmful: now the "goto alldone" can be dropped by 

reversing the sense of the associated test and using the big block I
moved a couple versions back (and didn't reindent on purpose) as the
body of the if statement.

There are now no gotos in namei_oneroot, only normal loop logic.
This commit is contained in:
dholland 2011-04-18 00:47:04 +00:00
parent d5da8807ec
commit 34cecc956d
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/kern/vfs_lookup.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: vfs_lookup.c,v 1.181 2011/04/18 00:46:39 dholland Exp $ */
/* $NetBSD: vfs_lookup.c,v 1.182 2011/04/18 00:47:04 dholland Exp $ */
/*
* Copyright (c) 1982, 1986, 1989, 1993
@ -37,7 +37,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.181 2011/04/18 00:46:39 dholland Exp $");
__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.182 2011/04/18 00:47:04 dholland Exp $");
#include "opt_magiclinks.h"
@ -1264,11 +1264,7 @@ namei_oneroot(struct namei_state *state, struct vnode *forcecwd,
break;
}
if (foundobj == NULL) {
goto alldone;
}
{
if (foundobj != NULL) {
if (foundobj == ndp->ni_erootdir) {
/*
* We are about to return the emulation root.
@ -1357,8 +1353,6 @@ namei_oneroot(struct namei_state *state, struct vnode *forcecwd,
}
}
alldone:
/*
* Done.
*/