Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop pointer checks that are always true.

This commit is contained in:
joerg 2014-11-15 01:15:45 +00:00
parent 8820e4401c
commit 31a77d8abb
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
external/bsd/iscsi/dist/src/lib/parameters.c vendored
View File

@ -919,12 +919,7 @@ answer:
if (strcmp(value, "?") == 0) {
iscsi_trace(TRACE_ISCSI_PARAM, "got inquiry for param \"%s\"\n", param->key);
if (param->value_l) {
if (param->value_l->value) {
(void) strlcpy(param->answer_tx, param->value_l->value, sizeof(param->answer_tx));
} else {
iscsi_err(__FILE__, __LINE__, "param \"%s\" has NULL value_l->value\n", param->key);
param->answer_tx[0] = 0x0;
}
(void) strlcpy(param->answer_tx, param->value_l->value, sizeof(param->answer_tx));
} else {
iscsi_err(__FILE__, __LINE__, "param \"%s\" has NULL value_l\n", param->key);
param->answer_tx[0] = 0x0;

3
external/bsd/iscsi/dist/src/lib/target.c vendored
View File

@ -762,8 +762,7 @@ text_command_t(target_session_t * sess, uint8_t *header)
return -1;
}
if (ptr->rx_offer) {
if (ptr->offer_rx &&
strcmp(ptr->offer_rx, "All") == 0 &&
if (strcmp(ptr->offer_rx, "All") == 0 &&
!param_equiv(sess->params, "SessionType",
"Discovery")) {
iscsi_trace(TRACE_ISCSI_DEBUG,