Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity CID 1774, 1773: Don't leak open file descriptors or leave temp 

file turds on error.
This commit is contained in:
christos 2006-04-25 18:02:02 +00:00
parent d67db6407e
commit 313c1811bf
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/cron/crontab.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: crontab.c,v 1.26 2005/03/16 02:53:55 xtraeme Exp $ */ /* $NetBSD: crontab.c,v 1.27 2006/04/25 18:02:02 christos Exp $ */
/* Copyright 1988,1990,1993,1994 by Paul Vixie /* Copyright 1988,1990,1993,1994 by Paul Vixie
* All rights reserved * All rights reserved
@ -22,7 +22,7 @@
#if 0 #if 0
static char rcsid[] = "Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp"; static char rcsid[] = "Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp";
#else #else
__RCSID("$NetBSD: crontab.c,v 1.26 2005/03/16 02:53:55 xtraeme Exp $"); __RCSID("$NetBSD: crontab.c,v 1.27 2006/04/25 18:02:02 christos Exp $");
#endif #endif
#endif #endif
@ -562,12 +562,14 @@ replace_cmd(void) {
if (fstat(fileno(NewCrontab), &statbuf)) { if (fstat(fileno(NewCrontab), &statbuf)) {
fprintf(stderr, "%s: error stat'ing crontab input: %s\n", fprintf(stderr, "%s: error stat'ing crontab input: %s\n",
ProgramName, strerror(errno)); ProgramName, strerror(errno));
fclose(tmp); unlink(tn);
return(-2); return(-2);
} }
if (statbuf.st_size > maxtabsize) { if (statbuf.st_size > maxtabsize) {
fprintf(stderr, fprintf(stderr,
"%s: %ld bytes is larger than the maximum size of %ld bytes\n", "%s: %ld bytes is larger than the maximum size of %ld bytes\n",
ProgramName, (long) statbuf.st_size, (long) maxtabsize); ProgramName, (long) statbuf.st_size, (long) maxtabsize);
fclose(tmp); unlink(tn);
return(-1); return(-1);
} }
@ -578,7 +580,7 @@ replace_cmd(void) {
fprintf(tmp, "# DO NOT EDIT THIS FILE - edit the master and reinstall.\n"); fprintf(tmp, "# DO NOT EDIT THIS FILE - edit the master and reinstall.\n");
fprintf(tmp, "# (%s installed on %-24.24s)\n", Filename, ctime(&now)); fprintf(tmp, "# (%s installed on %-24.24s)\n", Filename, ctime(&now));
fprintf(tmp, "# (Cron version -- %s)\n", fprintf(tmp, "# (Cron version -- %s)\n",
"$NetBSD: crontab.c,v 1.26 2005/03/16 02:53:55 xtraeme Exp $"); "$NetBSD: crontab.c,v 1.27 2006/04/25 18:02:02 christos Exp $");
/* copy the crontab to the tmp /* copy the crontab to the tmp
*/ */