Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Moved the errno=0 in the loop for opening the temp file. The problem was that 

successful syscalls never set errno, and hence we could have had an inifinite
loop if the opening failed once and succeded on second attempt.
This commit is contained in:
manu 2001-07-13 15:54:22 +00:00
parent 340af7db82
commit 2e20a48c80
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/dev_mkdb/dev_mkdb.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: dev_mkdb.c,v 1.14 2001/07/12 20:46:39 manu Exp $ */ /* $NetBSD: dev_mkdb.c,v 1.15 2001/07/13 15:54:22 manu Exp $ */
/*- /*-
* Copyright (c) 1990, 1993 * Copyright (c) 1990, 1993
@ -43,7 +43,7 @@ __COPYRIGHT("@(#) Copyright (c) 1990, 1993\n\
#if 0 #if 0
static char sccsid[] = "from: @(#)dev_mkdb.c 8.1 (Berkeley) 6/6/93"; static char sccsid[] = "from: @(#)dev_mkdb.c 8.1 (Berkeley) 6/6/93";
#else #else
__RCSID("$NetBSD: dev_mkdb.c,v 1.14 2001/07/12 20:46:39 manu Exp $"); __RCSID("$NetBSD: dev_mkdb.c,v 1.15 2001/07/13 15:54:22 manu Exp $");
#endif #endif
#endif /* not lint */ #endif /* not lint */
@ -137,7 +137,6 @@ main(argc, argv)
*/ */
(void)strncpy(dbtmp, dbname, MAXPATHLEN); (void)strncpy(dbtmp, dbname, MAXPATHLEN);
q = rindex(dbtmp, '/'); q = rindex(dbtmp, '/');
errno = 0;
do { do {
(void)gettimeofday(&tv, NULL); (void)gettimeofday(&tv, NULL);
if (q) { if (q) {
@ -147,6 +146,7 @@ main(argc, argv)
(void)snprintf(dbtmp, MAXPATHLEN, "./%s.%ld.tmp", (void)snprintf(dbtmp, MAXPATHLEN, "./%s.%ld.tmp",
dbname, tv.tv_usec); dbname, tv.tv_usec);
} }
errno = 0;
db = dbopen(dbtmp, O_CREAT|O_EXCL|O_EXLOCK|O_RDWR|O_TRUNC, db = dbopen(dbtmp, O_CREAT|O_EXCL|O_EXLOCK|O_RDWR|O_TRUNC,
S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, DB_HASH, NULL); S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, DB_HASH, NULL);
} while (errno == EEXIST); } while (errno == EEXIST);