Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert previous change to dwc_gmac_txintr() - while it looks strange at 

first sight (and sorry I didn't spot it when reviewing), it is a small
optimization and actually correct.
Add a comment explaining it.
This commit is contained in:
martin 2014-11-23 11:08:16 +00:00
parent 87318503e5
commit 2d00f56cae
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/dev/ic/dwc_gmac.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: dwc_gmac.c,v 1.25 2014/11/22 18:31:03 jmcneill Exp $ */ /* $NetBSD: dwc_gmac.c,v 1.26 2014/11/23 11:08:16 martin Exp $ */
/*- /*-
* Copyright (c) 2013, 2014 The NetBSD Foundation, Inc. * Copyright (c) 2013, 2014 The NetBSD Foundation, Inc.
@ -41,7 +41,7 @@
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(1, "$NetBSD: dwc_gmac.c,v 1.25 2014/11/22 18:31:03 jmcneill Exp $"); __KERNEL_RCSID(1, "$NetBSD: dwc_gmac.c,v 1.26 2014/11/23 11:08:16 martin Exp $");
/* #define DWC_GMAC_DEBUG 1 */ /* #define DWC_GMAC_DEBUG 1 */
@ -982,7 +982,12 @@ dwc_gmac_tx_intr(struct dwc_gmac_softc *sc)
#endif #endif
desc = &sc->sc_txq.t_desc[i]; desc = &sc->sc_txq.t_desc[i];
dwc_gmac_txdesc_sync(sc, i, TX_NEXT(i), /*
* i+1 does not need to be a valid descriptor,
* this is just a special notion to just sync
* a single tx descriptor (i)
*/
dwc_gmac_txdesc_sync(sc, i, i+1,
BUS_DMASYNC_POSTREAD|BUS_DMASYNC_POSTWRITE); BUS_DMASYNC_POSTREAD|BUS_DMASYNC_POSTWRITE);
flags = le32toh(desc->ddesc_status); flags = le32toh(desc->ddesc_status);