Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Acquire proclist_lock across the calls to p_find() and pg_find().

This commit is contained in:
dsl 2007-02-17 21:40:19 +00:00
parent 10c063a777
commit 2b491f69ce
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/compat/linux/common/linux_file.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: linux_file.c,v 1.77 2007/02/09 21:55:19 ad Exp $ */
/* $NetBSD: linux_file.c,v 1.78 2007/02/17 21:40:19 dsl Exp $ */
/*-
* Copyright (c) 1995, 1998 The NetBSD Foundation, Inc.
@ -42,7 +42,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: linux_file.c,v 1.77 2007/02/09 21:55:19 ad Exp $");
__KERNEL_RCSID(0, "$NetBSD: linux_file.c,v 1.78 2007/02/17 21:40:19 dsl Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@ -461,18 +461,22 @@ linux_sys_fcntl(l, v, retval)
retval[0] = tp->t_pgrp ? tp->t_pgrp->pg_id : NO_PGID;
return 0;
}
rw_enter(&proclist_lock, RW_READER);
if ((long)arg <= 0) {
pgid = -(long)arg;
} else {
struct proc *p1 = pfind((long)arg);
struct proc *p1 = p_find((long)arg, PFIND_LOCKED | PFIND_UNLOCK_FAIL);
if (p1 == NULL)
return (ESRCH);
pgid = (long)p1->p_pgrp->pg_id;
}
pgrp = pgfind(pgid);
if (pgrp == NULL || pgrp->pg_session != p->p_session)
pgrp = pg_find(pgid, PFIND_LOCKED);
if (pgrp == NULL || pgrp->pg_session != p->p_session) {
rw_exit(&proclist_lock);
return EPERM;
}
tp->t_pgrp = pgrp;
rw_exit(&proclist_lock);
return 0;
default: