Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pull up following revision(s) (requested by uwe in ticket #1574): 

lib/libcurses/newwin.c: revision 1.58

newwin - fix crash with negative ncols.

When support for negative nrows/ncols was added, one s/ncols/maxx/ was
missed so we ended up passing negative (i.e. huge unsigned) length
when hashing the line contents.

Reported by Naman Jain in PR lib/55484
This commit is contained in:
martin 2020-07-14 13:39:09 +00:00
parent b7a23bb3e0
commit 27a677be32
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/libcurses/newwin.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: newwin.c,v 1.50.6.3 2018/10/09 10:01:38 martin Exp $ */
/* $NetBSD: newwin.c,v 1.50.6.4 2020/07/14 13:39:09 martin Exp $ */
/*
* Copyright (c) 1981, 1993, 1994
@ -34,7 +34,7 @@
#if 0
static char sccsid[] = "@(#)newwin.c 8.3 (Berkeley) 7/27/94";
#else
__RCSID("$NetBSD: newwin.c,v 1.50.6.3 2018/10/09 10:01:38 martin Exp $");
__RCSID("$NetBSD: newwin.c,v 1.50.6.4 2020/07/14 13:39:09 martin Exp $");
#endif
#endif /* not lint */
@ -174,7 +174,7 @@ __newwin(SCREEN *screen, int nlines, int ncols, int by, int bx, int ispad,
#endif /* HAVE_WCHAR */
}
lp->hash = __hash((char *)(void *)lp->line,
(size_t)(ncols * __LDATASIZE));
(size_t)(maxx * __LDATASIZE));
}
return (win);
}