KNF the code and fix three bugs:
* If a non-zero addr was given to rbus_space_alloc_subregion() it would claim to have allocated region when in fact it just failed. * If a non-zero addr was given to rbus_space_alloc_subregion() allocation often (always?) failed when it shouldn't. * One part of rbus_space_alloc_subregion() used an alignment that always made the kernel panic. I'm not sure if my change is correct, because I don't know what this code is supposed to do. But now I can use a 3c562 card.
This commit is contained in:
parent
fd36bc02a6
commit
20edddd023
@ -1,4 +1,4 @@
|
||||
/* $NetBSD: rbus.c,v 1.3 1999/11/06 06:20:53 soren Exp $ */
|
||||
/* $NetBSD: rbus.c,v 1.4 2000/05/08 14:00:05 augustss Exp $ */
|
||||
/*
|
||||
* Copyright (c) 1999
|
||||
* HAYAKAWA Koichi. All rights reserved.
|
||||
@ -42,7 +42,7 @@
|
||||
|
||||
#include <dev/cardbus/rbus.h>
|
||||
|
||||
/* #define RBUS_DEBUG */
|
||||
/*#define RBUS_DEBUG*/
|
||||
|
||||
#if defined RBUS_DEBUG
|
||||
#define STATIC
|
||||
@ -63,16 +63,16 @@ static rbus_tag_t rbus_new_body __P((bus_space_tag_t bt, rbus_tag_t parent,
|
||||
|
||||
int
|
||||
rbus_space_alloc(rbt, addr, size, mask, align, flags, addrp, bshp)
|
||||
rbus_tag_t rbt;
|
||||
bus_addr_t addr;
|
||||
bus_size_t size;
|
||||
bus_addr_t mask, align;
|
||||
int flags;
|
||||
bus_addr_t *addrp;
|
||||
bus_space_handle_t *bshp;
|
||||
rbus_tag_t rbt;
|
||||
bus_addr_t addr;
|
||||
bus_size_t size;
|
||||
bus_addr_t mask, align;
|
||||
int flags;
|
||||
bus_addr_t *addrp;
|
||||
bus_space_handle_t *bshp;
|
||||
{
|
||||
return rbus_space_alloc_subregion(rbt, rbt->rb_start, rbt->rb_end, addr,
|
||||
size, mask, align, flags, addrp, bshp);
|
||||
return rbus_space_alloc_subregion(rbt, rbt->rb_start, rbt->rb_end,
|
||||
addr, size, mask, align, flags, addrp, bshp);
|
||||
}
|
||||
|
||||
|
||||
@ -80,129 +80,118 @@ rbus_space_alloc(rbt, addr, size, mask, align, flags, addrp, bshp)
|
||||
|
||||
int
|
||||
rbus_space_alloc_subregion(rbt, substart, subend, addr, size, mask, align, flags, addrp, bshp)
|
||||
rbus_tag_t rbt;
|
||||
bus_addr_t addr;
|
||||
bus_addr_t substart;
|
||||
bus_addr_t subend;
|
||||
bus_size_t size;
|
||||
bus_addr_t mask, align;
|
||||
int flags;
|
||||
bus_addr_t *addrp;
|
||||
bus_space_handle_t *bshp;
|
||||
rbus_tag_t rbt;
|
||||
bus_addr_t addr;
|
||||
bus_addr_t substart;
|
||||
bus_addr_t subend;
|
||||
bus_size_t size;
|
||||
bus_addr_t mask, align;
|
||||
int flags;
|
||||
bus_addr_t *addrp;
|
||||
bus_space_handle_t *bshp;
|
||||
{
|
||||
bus_addr_t decodesize = mask + 1;
|
||||
bus_addr_t boundary, search_addr;
|
||||
int val = 0;
|
||||
bus_addr_t result;
|
||||
int exflags = EX_FAST | EX_NOWAIT;
|
||||
bus_addr_t decodesize = mask + 1;
|
||||
bus_addr_t boundary, search_addr;
|
||||
int val;
|
||||
bus_addr_t result;
|
||||
u_long ures;
|
||||
int exflags = EX_FAST | EX_NOWAIT;
|
||||
|
||||
DPRINTF(("rbus_space_alloc: addr %lx, size %lx, mask %lx, align %lx\n",
|
||||
addr, size, mask, align));
|
||||
DPRINTF(("rbus_space_alloc: addr 0x%lx, size 0x%lx, mask 0x%lx, "
|
||||
"align 0x%lx, substart 0x%lx, subend 0x%lx\n",
|
||||
addr, size, mask, align, substart, subend));
|
||||
|
||||
addr += rbt->rb_offset;
|
||||
addr += rbt->rb_offset;
|
||||
|
||||
if (mask == 0) {
|
||||
/* FULL Decode */
|
||||
decodesize = 0;
|
||||
}
|
||||
if (mask == 0)
|
||||
/* FULL Decode */
|
||||
decodesize = 0;
|
||||
|
||||
if (rbt->rb_flags == RBUS_SPACE_ASK_PARENT) {
|
||||
return rbus_space_alloc(rbt->rb_parent, addr, size, mask, align, flags,
|
||||
addrp, bshp);
|
||||
} else if (rbt->rb_flags == RBUS_SPACE_SHARE ||
|
||||
rbt->rb_flags == RBUS_SPACE_DEDICATE) {
|
||||
/* rbt has its own sh_extent */
|
||||
if (rbt->rb_flags == RBUS_SPACE_ASK_PARENT)
|
||||
return rbus_space_alloc(rbt->rb_parent, addr, size, mask,
|
||||
align, flags, addrp, bshp);
|
||||
|
||||
/* sanity check: the subregion [substart, subend] should be
|
||||
smaller than the region included in sh_extent */
|
||||
if (substart < rbt->rb_ext->ex_start || subend > rbt->rb_ext->ex_end) {
|
||||
return 1;
|
||||
}
|
||||
if (rbt->rb_flags != RBUS_SPACE_SHARE &&
|
||||
rbt->rb_flags != RBUS_SPACE_DEDICATE)
|
||||
return 1;
|
||||
|
||||
if (decodesize == align) {
|
||||
if(extent_alloc_subregion(rbt->rb_ext, substart, subend, size, align, 0,
|
||||
exflags, (u_long *)&result)) {
|
||||
return 1;
|
||||
}
|
||||
} else if (decodesize == 0) {
|
||||
/* maybe, the resister is overflowed. */
|
||||
|
||||
if (extent_alloc_subregion(rbt->rb_ext, addr, addr + size, size,
|
||||
0, 0, exflags, (u_long *)&result)) {
|
||||
return 1;
|
||||
}
|
||||
} else {
|
||||
/* rbt has its own sh_extent */
|
||||
|
||||
boundary = decodesize > align ? decodesize : align;
|
||||
/* sanity check: the subregion [substart, subend] should be
|
||||
smaller than the region included in sh_extent */
|
||||
if (substart < rbt->rb_ext->ex_start || subend > rbt->rb_ext->ex_end)
|
||||
return 1;
|
||||
|
||||
search_addr = (substart & ~(boundary - 1)) + addr;
|
||||
if (decodesize == align) {
|
||||
if (extent_alloc_subregion(rbt->rb_ext, substart, subend,
|
||||
size, align, 0, exflags, &ures)) {
|
||||
return 1;
|
||||
}
|
||||
} else if (decodesize == 0 || addr != 0) {
|
||||
/* maybe, the register is overflowed. */
|
||||
if (extent_alloc_subregion(rbt->rb_ext, addr, addr + size,
|
||||
size, 1, 0, exflags, &ures)) {
|
||||
return 1;
|
||||
}
|
||||
} else {
|
||||
boundary = decodesize > align ? decodesize : align;
|
||||
search_addr = (substart & ~(boundary - 1)) + addr;
|
||||
|
||||
if (search_addr < substart) {
|
||||
search_addr += boundary;
|
||||
}
|
||||
if (search_addr < substart)
|
||||
search_addr += boundary;
|
||||
|
||||
for (; search_addr + size <= subend; search_addr += boundary) {
|
||||
val = extent_alloc_subregion(rbt->rb_ext,search_addr, search_addr+size,
|
||||
size, align, 0, exflags, (u_long *)&result);
|
||||
if (val == 0) {
|
||||
break;
|
||||
val = 1;
|
||||
for (; search_addr + size <= subend; search_addr += boundary) {
|
||||
val = extent_alloc_subregion(rbt->rb_ext, search_addr,
|
||||
search_addr + size, size, align, 0, exflags,
|
||||
&ures);
|
||||
if (val == 0)
|
||||
break;
|
||||
}
|
||||
if (val)
|
||||
return 1;
|
||||
}
|
||||
}
|
||||
if (val) {
|
||||
return 1;
|
||||
}
|
||||
}
|
||||
result = (bus_addr_t)ures;
|
||||
|
||||
if(md_space_map(rbt->rb_bt, result, size, flags, bshp)) {
|
||||
/* map failed */
|
||||
extent_free(rbt->rb_ext, result, size, exflags);
|
||||
return 1;
|
||||
}
|
||||
if (md_space_map(rbt->rb_bt, result, size, flags, bshp)) {
|
||||
/* map failed */
|
||||
extent_free(rbt->rb_ext, result, size, exflags);
|
||||
return 1;
|
||||
}
|
||||
|
||||
if (addrp != NULL) {
|
||||
*addrp = result + rbt->rb_offset;
|
||||
}
|
||||
return 0;
|
||||
|
||||
} else {
|
||||
/* error!! */
|
||||
return 1;
|
||||
}
|
||||
return 1;
|
||||
if (addrp != NULL)
|
||||
*addrp = result + rbt->rb_offset;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
int
|
||||
rbus_space_free(rbt, bsh, size, addrp)
|
||||
rbus_tag_t rbt;
|
||||
bus_space_handle_t bsh;
|
||||
bus_size_t size;
|
||||
bus_addr_t *addrp;
|
||||
rbus_tag_t rbt;
|
||||
bus_space_handle_t bsh;
|
||||
bus_size_t size;
|
||||
bus_addr_t *addrp;
|
||||
{
|
||||
int exflags = EX_FAST | EX_NOWAIT;
|
||||
bus_addr_t addr;
|
||||
int status = 1;
|
||||
int exflags = EX_FAST | EX_NOWAIT;
|
||||
bus_addr_t addr;
|
||||
int status = 1;
|
||||
|
||||
if (rbt->rb_flags == RBUS_SPACE_ASK_PARENT) {
|
||||
status = rbus_space_free(rbt->rb_parent, bsh, size, &addr);
|
||||
} else if (rbt->rb_flags == RBUS_SPACE_SHARE ||
|
||||
rbt->rb_flags == RBUS_SPACE_DEDICATE) {
|
||||
md_space_unmap(rbt->rb_bt, bsh, size, &addr);
|
||||
if (rbt->rb_flags == RBUS_SPACE_ASK_PARENT) {
|
||||
status = rbus_space_free(rbt->rb_parent, bsh, size, &addr);
|
||||
} else if (rbt->rb_flags == RBUS_SPACE_SHARE ||
|
||||
rbt->rb_flags == RBUS_SPACE_DEDICATE) {
|
||||
md_space_unmap(rbt->rb_bt, bsh, size, &addr);
|
||||
|
||||
extent_free(rbt->rb_ext, addr, size, exflags);
|
||||
extent_free(rbt->rb_ext, addr, size, exflags);
|
||||
|
||||
status = 0;
|
||||
} else {
|
||||
/* error. INVALID rbustag */
|
||||
status = 1;
|
||||
}
|
||||
if (addrp != NULL) {
|
||||
*addrp = addr;
|
||||
}
|
||||
return status;
|
||||
status = 0;
|
||||
} else {
|
||||
/* error. INVALID rbustag */
|
||||
status = 1;
|
||||
}
|
||||
if (addrp != NULL)
|
||||
*addrp = addr;
|
||||
return status;
|
||||
}
|
||||
|
||||
|
||||
@ -216,43 +205,42 @@ rbus_space_free(rbt, bsh, size, addrp)
|
||||
*/
|
||||
static rbus_tag_t
|
||||
rbus_new_body(bt, parent, ex, start, end, offset, flags)
|
||||
bus_space_tag_t bt;
|
||||
rbus_tag_t parent;
|
||||
struct extent *ex;
|
||||
bus_addr_t start, end, offset;
|
||||
int flags;
|
||||
bus_space_tag_t bt;
|
||||
rbus_tag_t parent;
|
||||
struct extent *ex;
|
||||
bus_addr_t start, end, offset;
|
||||
int flags;
|
||||
{
|
||||
rbus_tag_t rb;
|
||||
rbus_tag_t rb;
|
||||
|
||||
/* sanity check */
|
||||
if (parent != NULL) {
|
||||
if (start < parent->rb_start || end > parent->rb_end) {
|
||||
/* out of range: [start, size] should be containd in parent space */
|
||||
return 0;
|
||||
/* Should I invoke panic? */
|
||||
}
|
||||
}
|
||||
/* sanity check */
|
||||
if (parent != NULL) {
|
||||
if (start < parent->rb_start || end > parent->rb_end) {
|
||||
/* out of range: [start, size] should be containd in parent space */
|
||||
return 0;
|
||||
/* Should I invoke panic? */
|
||||
}
|
||||
}
|
||||
|
||||
if (NULL == (rb = (rbus_tag_t)malloc(sizeof(struct rbustag), M_DEVBUF,
|
||||
M_NOWAIT))) {
|
||||
panic("no memory for rbus instance");
|
||||
}
|
||||
rb = (rbus_tag_t)malloc(sizeof(struct rbustag), M_DEVBUF, M_NOWAIT);
|
||||
if (rb == NULL)
|
||||
panic("no memory for rbus instance");
|
||||
|
||||
rb->rb_bt = bt;
|
||||
rb->rb_parent = parent;
|
||||
rb->rb_start = start;
|
||||
rb->rb_end = end;
|
||||
rb->rb_offset = offset;
|
||||
rb->rb_flags = flags;
|
||||
rb->rb_ext = ex;
|
||||
rb->rb_bt = bt;
|
||||
rb->rb_parent = parent;
|
||||
rb->rb_start = start;
|
||||
rb->rb_end = end;
|
||||
rb->rb_offset = offset;
|
||||
rb->rb_flags = flags;
|
||||
rb->rb_ext = ex;
|
||||
|
||||
DPRINTF(("rbus_new_body: [%lx, %lx] type %s name [%s]\n", start, end,
|
||||
flags == RBUS_SPACE_SHARE ? "share" :
|
||||
flags == RBUS_SPACE_DEDICATE ? "dedicated" :
|
||||
flags == RBUS_SPACE_ASK_PARENT ? "parent" : "invalid",
|
||||
ex != NULL ? ex->ex_name : "noname"));
|
||||
DPRINTF(("rbus_new_body: [%lx, %lx] type %s name [%s]\n", start, end,
|
||||
flags == RBUS_SPACE_SHARE ? "share" :
|
||||
flags == RBUS_SPACE_DEDICATE ? "dedicated" :
|
||||
flags == RBUS_SPACE_ASK_PARENT ? "parent" : "invalid",
|
||||
ex != NULL ? ex->ex_name : "noname"));
|
||||
|
||||
return rb;
|
||||
return rb;
|
||||
}
|
||||
|
||||
|
||||
@ -265,39 +253,39 @@ rbus_new_body(bt, parent, ex, start, end, offset, flags)
|
||||
*/
|
||||
rbus_tag_t
|
||||
rbus_new(parent, start, size, offset, flags)
|
||||
rbus_tag_t parent;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
int flags;
|
||||
rbus_tag_t parent;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
int flags;
|
||||
{
|
||||
rbus_tag_t rb;
|
||||
struct extent *ex = NULL;
|
||||
bus_addr_t end = start + size;
|
||||
rbus_tag_t rb;
|
||||
struct extent *ex = NULL;
|
||||
bus_addr_t end = start + size;
|
||||
|
||||
if (flags == RBUS_SPACE_SHARE) {
|
||||
ex = parent->rb_ext;
|
||||
} else if (flags == RBUS_SPACE_DEDICATE) {
|
||||
if (NULL == (ex = extent_create("rbus", start, end, M_DEVBUF, NULL, 0,
|
||||
EX_NOCOALESCE|EX_NOWAIT))) {
|
||||
free(rb, M_DEVBUF);
|
||||
return NULL;
|
||||
}
|
||||
} else if (flags == RBUS_SPACE_ASK_PARENT) {
|
||||
ex = NULL;
|
||||
} else {
|
||||
/* Invalid flag */
|
||||
return 0;
|
||||
}
|
||||
if (flags == RBUS_SPACE_SHARE) {
|
||||
ex = parent->rb_ext;
|
||||
} else if (flags == RBUS_SPACE_DEDICATE) {
|
||||
ex = extent_create("rbus", start, end, M_DEVBUF, NULL, 0,
|
||||
EX_NOCOALESCE | EX_NOWAIT);
|
||||
if (ex == NULL) {
|
||||
free(rb, M_DEVBUF);
|
||||
return NULL;
|
||||
}
|
||||
} else if (flags == RBUS_SPACE_ASK_PARENT) {
|
||||
ex = NULL;
|
||||
} else {
|
||||
/* Invalid flag */
|
||||
return NULL;
|
||||
}
|
||||
|
||||
rb = rbus_new_body(parent->rb_bt, parent, ex, start, start + size,
|
||||
offset, flags);
|
||||
rb = rbus_new_body(parent->rb_bt, parent, ex, start, start + size,
|
||||
offset, flags);
|
||||
|
||||
if (rb == NULL && flags == RBUS_SPACE_DEDICATE)
|
||||
extent_destroy(ex);
|
||||
|
||||
if ((rb == NULL) && (flags == RBUS_SPACE_DEDICATE)) {
|
||||
extent_destroy(ex);
|
||||
}
|
||||
|
||||
return rb;
|
||||
return rb;
|
||||
}
|
||||
|
||||
|
||||
@ -311,27 +299,26 @@ rbus_new(parent, start, size, offset, flags)
|
||||
*/
|
||||
rbus_tag_t
|
||||
rbus_new_root_delegate(bt, start, size, offset)
|
||||
bus_space_tag_t bt;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
bus_space_tag_t bt;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
{
|
||||
rbus_tag_t rb;
|
||||
struct extent *ex;
|
||||
rbus_tag_t rb;
|
||||
struct extent *ex;
|
||||
|
||||
if (NULL == (ex = extent_create("rbus root", start, start + size, M_DEVBUF,
|
||||
NULL, 0, EX_NOCOALESCE|EX_NOWAIT))) {
|
||||
return NULL;
|
||||
}
|
||||
ex = extent_create("rbus root", start, start + size, M_DEVBUF,
|
||||
NULL, 0, EX_NOCOALESCE | EX_NOWAIT);
|
||||
if (ex == NULL)
|
||||
return NULL;
|
||||
|
||||
rb = rbus_new_body(bt, NULL, ex, start, start + size, offset,
|
||||
RBUS_SPACE_DEDICATE);
|
||||
rb = rbus_new_body(bt, NULL, ex, start, start + size, offset,
|
||||
RBUS_SPACE_DEDICATE);
|
||||
|
||||
if (rb == NULL) {
|
||||
extent_destroy(ex);
|
||||
}
|
||||
|
||||
return rb;
|
||||
if (rb == NULL)
|
||||
extent_destroy(ex);
|
||||
|
||||
return rb;
|
||||
}
|
||||
|
||||
|
||||
@ -344,21 +331,21 @@ rbus_new_root_delegate(bt, start, size, offset)
|
||||
*/
|
||||
rbus_tag_t
|
||||
rbus_new_root_share(bt, ex, start, size, offset)
|
||||
bus_space_tag_t bt;
|
||||
struct extent *ex;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
bus_space_tag_t bt;
|
||||
struct extent *ex;
|
||||
bus_addr_t start;
|
||||
bus_size_t size;
|
||||
bus_addr_t offset;
|
||||
{
|
||||
/* sanity check */
|
||||
if (start < ex->ex_start || start + size > ex->ex_end) {
|
||||
/* out of range: [start, size] should be containd in parent space */
|
||||
return 0;
|
||||
/* Should I invoke panic? */
|
||||
}
|
||||
/* sanity check */
|
||||
if (start < ex->ex_start || start + size > ex->ex_end) {
|
||||
/* out of range: [start, size] should be containd in parent space */
|
||||
return 0;
|
||||
/* Should I invoke panic? */
|
||||
}
|
||||
|
||||
return rbus_new_body(bt, NULL, ex, start, start + size, offset,
|
||||
RBUS_SPACE_SHARE);
|
||||
return rbus_new_body(bt, NULL, ex, start, start + size, offset,
|
||||
RBUS_SPACE_SHARE);
|
||||
}
|
||||
|
||||
|
||||
@ -372,15 +359,14 @@ rbus_new_root_share(bt, ex, start, size, offset)
|
||||
*/
|
||||
int
|
||||
rbus_delete(rb)
|
||||
rbus_tag_t rb;
|
||||
rbus_tag_t rb;
|
||||
{
|
||||
DPRINTF(("rbus_delete called [%s]\n",
|
||||
rb->rb_ext != NULL ? rb->rb_ext->ex_name : "noname"));
|
||||
if (rb->rb_flags == RBUS_SPACE_DEDICATE) {
|
||||
extent_destroy(rb->rb_ext);
|
||||
}
|
||||
DPRINTF(("rbus_delete called [%s]\n",
|
||||
rb->rb_ext != NULL ? rb->rb_ext->ex_name : "noname"));
|
||||
if (rb->rb_flags == RBUS_SPACE_DEDICATE)
|
||||
extent_destroy(rb->rb_ext);
|
||||
|
||||
free(rb, M_DEVBUF);
|
||||
free(rb, M_DEVBUF);
|
||||
|
||||
return 0;
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user