From 1f3cd4f95f0fd02986a7ddeecd6d4fd46a5d9a0d Mon Sep 17 00:00:00 2001
From: soren <soren@NetBSD.org>
Date: Wed, 5 Mar 2003 16:18:24 +0000
Subject: [PATCH] Be more verbose about unsupported keys.

---
 sys/arch/macppc/dev/abtn.c | 44 +++++++++++++++++++++++++++++++++-----
 1 file changed, 39 insertions(+), 5 deletions(-)

diff --git a/sys/arch/macppc/dev/abtn.c b/sys/arch/macppc/dev/abtn.c
index dfb1b7c579fe..a1ae45d7ef22 100644
--- a/sys/arch/macppc/dev/abtn.c
+++ b/sys/arch/macppc/dev/abtn.c
@@ -1,4 +1,4 @@
-/*	$NetBSD: abtn.c,v 1.5 2002/10/02 05:30:38 thorpej Exp $	*/
+/*	$NetBSD: abtn.c,v 1.6 2003/03/05 16:18:24 soren Exp $	*/
 
 /*-
  * Copyright (C) 1999 Tsubai Masanari.  All rights reserved.
@@ -36,6 +36,16 @@
 #define NVRAM_BRIGHTNESS 0x140e
 #define ABTN_HANDLER_ID 31
 
+#define BUTTON_LOUDER	0x06
+#define BUTTON_SOFTER	0x07
+#define BUTTON_MUTE	0x08
+#define BUTTON_BRIGHTER	0x09
+#define BUTTON_DIMMER	0x0a
+#define BUTTON_EJECT	0x0b
+#define BUTTON_DISPLAY	0x0c
+#define BUTTON_KEYPAD	0x7f
+#define BUTTON_DEPRESS	0x80
+
 struct abtn_softc {
 	struct device sc_dev;
 
@@ -79,8 +89,6 @@ abtn_attach(parent, self, aux)
 	ADBSetInfoBlock adbinfo;
 	int bright;
 
-	printf("brightness/volume button\n");
-
 	bright = pm_read_nvram(NVRAM_BRIGHTNESS);
 	if (bright != 0)
 		pm_set_brightness(bright);
@@ -106,8 +114,11 @@ abtn_adbcomplete(buffer, data, adb_command)
 
 	cmd = buffer[1];
 
+	if (cmd >= BUTTON_DEPRESS)
+		return;
+
 	switch (cmd) {
-	case 0x0a:
+	case BUTTON_DIMMER:
 		sc->brightness -= 8;
 		if (sc->brightness < 8)
 			sc->brightness = 8;
@@ -115,12 +126,35 @@ abtn_adbcomplete(buffer, data, adb_command)
 		pm_write_nvram(NVRAM_BRIGHTNESS, sc->brightness);
 		break;
 
-	case 0x09:
+	case BUTTON_BRIGHTER:
 		sc->brightness += 8;
 		if (sc->brightness > 0x78)
 			sc->brightness = 0x78;
 		pm_set_brightness(sc->brightness);
 		pm_write_nvram(NVRAM_BRIGHTNESS, sc->brightness);
 		break;
+
+	case BUTTON_MUTE:
+	case BUTTON_SOFTER:
+	case BUTTON_LOUDER:
+		printf("%s: volume setting not implemented\n",
+			sc->sc_dev.dv_xname);
+		break;
+	case BUTTON_DISPLAY:
+		printf("%s: display selection not implemented\n",
+			sc->sc_dev.dv_xname);
+		break;
+	case BUTTON_EJECT:
+		printf("%s: eject not implemented\n",
+			sc->sc_dev.dv_xname);
+		break;
+
+	/* The keyboard gets wacky when in keypad mode. */
+	case BUTTON_KEYPAD:
+		break;
+
+	default:
+		printf("%s: unknown button 0x%x\n",
+			sc->sc_dev.dv_xname, cmd);
 	}
 }