Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lint: warn about conversion from 128-bit to smaller integer types

This commit is contained in:
rillig 2023-07-08 12:45:43 +00:00
parent 5bb571bbdc
commit 1d389f0fa4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/usr.bin/xlint/lint1/platform_lp64.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: platform_lp64.c,v 1.6 2023/07/08 12:42:11 rillig Exp $ */
/* $NetBSD: platform_lp64.c,v 1.7 2023/07/08 12:45:43 rillig Exp $ */
# 3 "platform_lp64.c"
/*
@ -39,7 +39,8 @@ convert_unsigned_char_to_size_t(unsigned char uc)
void
convert_128(void)
{
/* TODO: Warn about 128-bit types as well. */
/* expect+1: warning: conversion from '__int128_t' to 'int' may lose accuracy [132] */
s32 = s128;
/* expect+1: warning: conversion from '__uint128_t' to 'unsigned int' may lose accuracy [132] */
u32 = u128;
}

7
usr.bin/xlint/lint1/tree.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: tree.c,v 1.551 2023/07/08 12:07:21 rillig Exp $ */
/* $NetBSD: tree.c,v 1.552 2023/07/08 12:45:43 rillig Exp $ */
/*
* Copyright (c) 1994, 1995 Jochen Pohl
@ -37,7 +37,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID)
__RCSID("$NetBSD: tree.c,v 1.551 2023/07/08 12:07:21 rillig Exp $");
__RCSID("$NetBSD: tree.c,v 1.552 2023/07/08 12:45:43 rillig Exp $");
#endif
#include <float.h>
@ -3447,8 +3447,7 @@ convert_integer_from_integer(op_t op, int arg, tspec_t nt, tspec_t ot,
if (aflag > 0 &&
portable_rank_cmp(nt, ot) < 0 &&
(ot == LONG || ot == ULONG || ot == LLONG || ot == ULLONG ||
aflag > 1) &&
(portable_rank_cmp(ot, LONG) >= 0 || aflag > 1) &&
// XXX: The portable_rank_cmp above aims at portable mode,
// independent of the current platform, while can_represent acts
// on the actual types from the current platform. This mix is