From 1d339cd8f07442c540d2eb453d9abe310d8e797b Mon Sep 17 00:00:00 2001 From: mlelstv Date: Sun, 22 Dec 2013 14:31:51 +0000 Subject: [PATCH] Resolve symlinks and cook the targets instead of the symlink names. --- lib/libutil/getdiskrawname.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/lib/libutil/getdiskrawname.c b/lib/libutil/getdiskrawname.c index 81f9ac7f35e3..ed1c21a40dcd 100644 --- a/lib/libutil/getdiskrawname.c +++ b/lib/libutil/getdiskrawname.c @@ -1,4 +1,4 @@ -/* $NetBSD: getdiskrawname.c,v 1.1 2012/04/07 16:44:39 christos Exp $ */ +/* $NetBSD: getdiskrawname.c,v 1.2 2013/12/22 14:31:51 mlelstv Exp $ */ /*- * Copyright (c) 2012 The NetBSD Foundation, Inc. @@ -29,7 +29,7 @@ * POSSIBILITY OF SUCH DAMAGE. */ #include -__RCSID("$NetBSD: getdiskrawname.c,v 1.1 2012/04/07 16:44:39 christos Exp $"); +__RCSID("$NetBSD: getdiskrawname.c,v 1.2 2013/12/22 14:31:51 mlelstv Exp $"); #include @@ -37,18 +37,26 @@ __RCSID("$NetBSD: getdiskrawname.c,v 1.1 2012/04/07 16:44:39 christos Exp $"); #include #include #include +#include const char * getdiskrawname(char *buf, size_t bufsiz, const char *name) { const char *dp = strrchr(name, '/'); struct stat st; + ssize_t len; if (dp == NULL) { errno = EINVAL; return NULL; } + len = readlink(name, buf, bufsiz-1); + if (len > 0) { + buf[len] = '\0'; + name = buf; + } + if (stat(name, &st) == -1) return NULL; @@ -67,11 +75,19 @@ getdiskcookedname(char *buf, size_t bufsiz, const char *name) { const char *dp; struct stat st; + ssize_t len; if ((dp = strrchr(name, '/')) == NULL) { errno = EINVAL; return NULL; } + + len = readlink(name, buf, bufsiz-1); + if (len > 0) { + buf[len] = '\0'; + name = buf; + } + if (stat(name, &st) == -1) return NULL; @@ -79,10 +95,12 @@ getdiskcookedname(char *buf, size_t bufsiz, const char *name) errno = EFTYPE; return NULL; } + if (dp[1] != 'r') { errno = EINVAL; return NULL; } + (void)snprintf(buf, bufsiz, "%.*s/%s", (int)(dp - name), name, dp + 2); return buf;