Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use "r" instead of "r+" to popen(3), since the latter is not portable

Browse Source 
and the I/O stream is only read from in any case. Problem noted and fix
suggested by Ben Harris <bjh21@netbsd.org> in [toolchain/16139].
This commit is contained in:
lukem 2002-03-31 07:48:15 +00:00
parent 15bab55a0c
commit 1cdb82d0a7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.bin/crunch/crunchgen/crunchgen.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: crunchgen.c,v 1.33 2002/02/02 12:25:35 lukem Exp $ */
/* $NetBSD: crunchgen.c,v 1.34 2002/03/31 07:48:15 lukem Exp $ */
/*
* Copyright (c) 1994 University of Maryland
* All Rights Reserved.
@ -33,7 +33,7 @@
*/
#include <sys/cdefs.h>
#if defined(__RCSID) && !defined(lint)
__RCSID("$NetBSD: crunchgen.c,v 1.33 2002/02/02 12:25:35 lukem Exp $");
__RCSID("$NetBSD: crunchgen.c,v 1.34 2002/03/31 07:48:15 lukem Exp $");
#endif
#if HAVE_CONFIG_H
@ -622,7 +622,7 @@ void fillin_program_objs(prog_t *p, char *dirpath)
(void)snprintf(line, sizeof(line),
"cd %s && %s CRUNCHEDPROG=1 -f %s %s crunchgen_objs 2>&1", dirpath,
makebin, tempfname, makeflags);
if((f = popen(line, "r+")) == NULL) {
if((f = popen(line, "r")) == NULL) {
perror("submake pipe");
goterror = 1;
unlink(tempfname);