Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make: separate cases in HandleDependencyTargetMundane 

Most targets do not use wildcards, so there is no need to put the single
item into a list.

No functional change.
This commit is contained in:
rillig 2022-06-11 17:41:35 +00:00
parent 8a67ed90c9
commit 1b9860a94b
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
usr.bin/make/parse.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: parse.c,v 1.677 2022/06/11 16:47:24 rillig Exp $ */
/* $NetBSD: parse.c,v 1.678 2022/06/11 17:41:35 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@ -105,7 +105,7 @@
#include "pathnames.h"
/* "@(#)parse.c 8.3 (Berkeley) 3/19/94" */
MAKE_RCSID("$NetBSD: parse.c,v 1.677 2022/06/11 16:47:24 rillig Exp $");
MAKE_RCSID("$NetBSD: parse.c,v 1.678 2022/06/11 17:41:35 rillig Exp $");
/*
* A file being read.
@ -1033,21 +1033,22 @@ HandleSingleDependencyTargetMundane(const char *name)
}
static void
HandleDependencyTargetMundane(char *targetName)
HandleDependencyTargetMundane(const char *targetName)
{
StringList targetNames = LST_INIT;
if (Dir_HasWildcards(targetName)) {
StringList targetNames = LST_INIT;
SearchPath *emptyPath = SearchPath_New();
SearchPath_Expand(emptyPath, targetName, &targetNames);
SearchPath_Free(emptyPath);
} else
Lst_Append(&targetNames, targetName);
while (!Lst_IsEmpty(&targetNames)) {
char *targName = Lst_Dequeue(&targetNames);
HandleSingleDependencyTargetMundane(targName);
}
while (!Lst_IsEmpty(&targetNames)) {
char *targName = Lst_Dequeue(&targetNames);
HandleSingleDependencyTargetMundane(targName);
/* TODO: free targName */
}
} else
HandleSingleDependencyTargetMundane(targetName);
}
static void