Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix filedescriptor leak 

Coverity CID 1625
This commit is contained in:
hubertf 2006-03-17 01:10:53 +00:00
parent 3ebb7ce790
commit 19dcd9a850
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
usr.sbin/pkg_install/lib/var.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: var.c,v 1.3 2005/11/06 12:40:02 wiz Exp $ */
/* $NetBSD: var.c,v 1.4 2006/03/17 01:10:53 hubertf Exp $ */
/*-
* Copyright (c) 2005 The NetBSD Foundation, Inc.
@ -40,7 +40,7 @@
#include <sys/cdefs.h>
#endif
#ifndef lint
__RCSID("$NetBSD: var.c,v 1.3 2005/11/06 12:40:02 wiz Exp $");
__RCSID("$NetBSD: var.c,v 1.4 2006/03/17 01:10:53 hubertf Exp $");
#endif
#if HAVE_SYS_STAT_H
@ -135,12 +135,14 @@ var_set(const char *fname, const char *variable, const char *value)
sprintf(tmpname, "%s.XXXXXX", fname);
if ((fd=mkstemp(tmpname)) < 0) {
free(tmpname);
fclose(fp);
warn("var_set: can't open temp file for '%s' for writing",
fname);
return -1;
}
if (chmod(tmpname, 0644) < 0) {
close(fd);
fclose(fp);
free(tmpname);
warn("var_set: can't set permissions for temp file for '%s'",
fname);
@ -150,6 +152,7 @@ var_set(const char *fname, const char *variable, const char *value)
close(fd);
remove(tmpname);
free(tmpname);
fclose(fp);
warn("var_set: can't open temp file for '%s' for writing",
fname);
return -1;