Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove partial-segment timestamp optimization from lfs_segmapv. If "time"

Browse Source 
is not monotonically increasing (e.g. clock is slaved to another system)
the optimization will result in segments being treated as corrupt
(uncleanable).  If enough such "bad" segments were created, the cleaner would
clean continuously, and after some time the system would panic with "no
clean segments".

(Legitimately old partial-segments are relatively rare, and will have their
blocks culled by lfs_bmapv.)
This commit is contained in:
perseant 1999-08-25 00:14:13 +00:00
parent 2e649e46d3
commit 193a2fa9f0
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libexec/lfs_cleanerd/library.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: library.c,v 1.12 1999/03/14 11:43:25 drochner Exp $ */
/* $NetBSD: library.c,v 1.13 1999/08/25 00:14:13 perseant Exp $ */
/*-
* Copyright (c) 1992, 1993
@ -38,7 +38,7 @@
#if 0
static char sccsid[] = "@(#)library.c 8.3 (Berkeley) 5/24/95";
#else
__RCSID("$NetBSD: library.c,v 1.12 1999/03/14 11:43:25 drochner Exp $");
__RCSID("$NetBSD: library.c,v 1.13 1999/08/25 00:14:13 perseant Exp $");
#endif
#endif /* not lint */
@ -342,7 +342,6 @@ lfs_segmapv(fsp, seg, seg_buf, blocks, bcount)
caddr_t s;
daddr_t pseg_addr, seg_addr;
int nelem, nblocks, nsegs, sumsize, i, ssize;
time_t timestamp;
i = 0;
lfsp = &fsp->fi_lfs;
@ -360,7 +359,7 @@ lfs_segmapv(fsp, seg, seg_buf, blocks, bcount)
*bcount = 0;
for (nsegs = 0, timestamp = 0; nsegs < sup->su_nsums; nsegs++) {
for (nsegs = 0; nsegs < sup->su_nsums; nsegs++) {
sp = (SEGSUM *)s;
nblocks = pseg_valid(fsp, sp, pseg_addr);
@ -372,11 +371,6 @@ lfs_segmapv(fsp, seg, seg_buf, blocks, bcount)
/* break; */
}
/* Check if we have hit old data */
if (timestamp > sp->ss_create)
break;
timestamp = sp->ss_create;
#ifdef DIAGNOSTIC
/* Verify size of summary block */
sumsize = sizeof(SEGSUM) +