Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Both carp.c and vlan.c expect for a keyword with a KW_T_STR-type 

value to put a prop_string_t into the environment, but the keyword
parser put a prop_data_t into the environment, instead.  That broke
the -vlanif and -carpdev keywords and defied developer expectations.
Let's put a prop_string_t into the environment.

Thanks to Arnaud Degroote for reporting the problem.
This commit is contained in:
dyoung 2009-07-28 18:21:06 +00:00
parent 3c24e51c76
commit 183dffe7f4
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sbin/ifconfig/parse.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: parse.c,v 1.13 2009/01/18 00:24:29 lukem Exp $ */
/* $NetBSD: parse.c,v 1.14 2009/07/28 18:21:06 dyoung Exp $ */
/*-
* Copyright (c) 2008 David Young. All rights reserved.
@ -27,7 +27,7 @@
#include <sys/cdefs.h>
#ifndef lint
__RCSID("$NetBSD: parse.c,v 1.13 2009/01/18 00:24:29 lukem Exp $");
__RCSID("$NetBSD: parse.c,v 1.14 2009/07/28 18:21:06 dyoung Exp $");
#endif /* not lint */
#include <err.h>
@ -685,8 +685,7 @@ pkw_match(const struct parser *p, const struct match *im,
o = u->u_obj;
break;
case KW_T_STR:
o = (prop_object_t)prop_data_create_data_nocopy(u->u_str,
strlen(u->u_str));
o = (prop_object_t)prop_string_create_cstring_nocopy(u->u_str);
if (o == NULL)
goto err;
break;