Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update tests for *env(3):

Browse Source 
- Introduce randomness into "t_setenv" to avoid freeing environment
  variables exactly in the order they have been allocated.
  Also call unsetenv(3) twice to make sure it behaves well if the
  environment variable doesn't exist.
- "t_getenv" is no longer a known failure after getenv(3) and getenv_r(3)
  have been fixed.
This commit is contained in:
tron 2010-11-14 18:15:08 +00:00
parent fbf4aa1699
commit 18217b5088
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tests/lib/libc/stdlib/t_environment.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: t_environment.c,v 1.9 2010/11/13 21:08:36 tron Exp $ */
/* $NetBSD: t_environment.c,v 1.10 2010/11/14 18:15:08 tron Exp $ */
/*-
* Copyright (c) 2010 The NetBSD Foundation, Inc.
* All rights reserved.
@ -32,7 +32,7 @@
*/
#include <sys/cdefs.h>
__RCSID("$NetBSD: t_environment.c,v 1.9 2010/11/13 21:08:36 tron Exp $");
__RCSID("$NetBSD: t_environment.c,v 1.10 2010/11/14 18:15:08 tron Exp $");
#include <atf-c.h>
#include <errno.h>
@ -79,21 +79,28 @@ ATF_TC_HEAD(t_getenv, tc)
ATF_TC_BODY(t_setenv, tc)
{
size_t i;
const size_t numvars = 8192;
size_t i, offset;
char name[1024];
char value[1024];
for (i = 0; i < 10240; i++) {
snprintf(name, sizeof(name), "var%zu", i);
snprintf(value, sizeof(value), "value%ld", lrand48());
offset = lrand48();
for (i = 0; i < numvars; i++) {
(void)snprintf(name, sizeof(name), "var%zu",
(i * 7 + offset) % numvars);
(void)snprintf(value, sizeof(value), "value%ld", lrand48());
ATF_CHECK(setenv(name, value, 1) != -1);
ATF_CHECK(setenv(name, "foo", 0) != -1);
ATF_CHECK_STREQ(getenv(name), value);
}
for (i = 0; i < 10240; i++) {
snprintf(name, sizeof(name), "var%zu", i);
offset = lrand48();
for (i = 0; i < numvars; i++) {
(void)snprintf(name, sizeof(name), "var%zu",
(i * 11 + offset) % numvars);
ATF_CHECK(unsetenv(name) != -1);
ATF_CHECK(getenv(name) == NULL);
ATF_CHECK(unsetenv(name) != -1);
}
ATF_CHECK_ERRNO(EINVAL, setenv(NULL, "val", 1) == -1);
@ -174,11 +181,7 @@ ATF_TC_BODY(t_getenv, tc)
{
ATF_CHECK(setenv("EVIL", "very=bad", 1) != -1);
ATF_CHECK_STREQ(getenv("EVIL"), "very=bad");
atf_tc_expect_fail("getenv(3) doesn't check variable names properly");
ATF_CHECK(getenv("EVIL=very") == NULL);
atf_tc_expect_pass();
ATF_CHECK(unsetenv("EVIL") != -1);
}