Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix signed vs. unsigned comparison in getgroups16() syscall. Negative

Browse Source 
gisetsize values now fail with EINVAL as expected.
This commit is contained in:
njoly 2014-05-20 17:31:18 +00:00
parent 30a02d27a2
commit 1815fcdd2a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/compat/linux/common/linux_uid16.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: linux_uid16.c,v 1.3 2008/05/20 15:48:24 njoly Exp $ */
/* $NetBSD: linux_uid16.c,v 1.4 2014/05/20 17:31:18 njoly Exp $ */
/*-
* Copyright (c) 1995, 1998 The NetBSD Foundation, Inc.
@ -30,7 +30,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: linux_uid16.c,v 1.3 2008/05/20 15:48:24 njoly Exp $");
__KERNEL_RCSID(0, "$NetBSD: linux_uid16.c,v 1.4 2014/05/20 17:31:18 njoly Exp $");
#include <sys/param.h>
#include <sys/proc.h>
@ -241,7 +241,7 @@ linux_sys_getgroups16(struct lwp *l, const struct linux_sys_getgroups16_args *ua
*retval = ngrps;
if (SCARG(uap, gidsetsize) == 0)
return 0;
if (SCARG(uap, gidsetsize) < ngrps)
if (SCARG(uap, gidsetsize) < (int)ngrps)
return EINVAL;
gidset = SCARG(uap, gidset);