Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fdtbus_get_string_index(): decrease len when going to the next string, 

otherwise we may read past the end of names.
This commit is contained in:
bouyer 2018-03-06 17:40:04 +00:00
parent f50e60a23f
commit 151eee193a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/fdt/fdt_subr.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: fdt_subr.c,v 1.20 2017/12/10 21:38:27 skrll Exp $ */
/* $NetBSD: fdt_subr.c,v 1.21 2018/03/06 17:40:04 bouyer Exp $ */
/*-
* Copyright (c) 2015 Jared D. McNeill <jmcneill@invisible.ca>
@ -27,7 +27,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: fdt_subr.c,v 1.20 2017/12/10 21:38:27 skrll Exp $");
__KERNEL_RCSID(0, "$NetBSD: fdt_subr.c,v 1.21 2018/03/06 17:40:04 bouyer Exp $");
#include <sys/param.h>
#include <sys/bus.h>
@ -467,7 +467,7 @@ fdtbus_get_string_index(int phandle, const char *prop, u_int index)
names = fdtbus_get_string(phandle, prop);
for (name = names, cur = 0; len > 0;
name += strlen(name) + 1, cur++) {
len -= strlen(name) + 1, name += strlen(name) + 1, cur++) {
if (index == cur)
return name;
}