Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Default simple_lock_debugger to "on" on MULTIPROCESSOR.

Browse Source 
Change uninitialized simple_lock check from KASSERT to use SLOCK_WHERE
(to show the "real" source line where the error was detected).
This commit is contained in:
sommerfeld 2000-08-23 15:17:47 +00:00
parent 101d6677d2
commit 11eae2ffaf
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/kern/kern_lock.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: kern_lock.c,v 1.44 2000/08/22 19:47:26 thorpej Exp $ */
/* $NetBSD: kern_lock.c,v 1.45 2000/08/23 15:17:47 sommerfeld Exp $ */
/*-
* Copyright (c) 1999, 2000 The NetBSD Foundation, Inc.
@ -788,7 +788,11 @@ u_long simple_locks;
#endif /* MULTIPROCESSOR */ /* } */
#ifdef DDB /* { */
#ifdef MULTIPROCESSOR
int simple_lock_debugger = 1; /* more serious on MP */
#else
int simple_lock_debugger = 0;
#endif
#define SLOCK_DEBUGGER() if (simple_lock_debugger) Debugger()
#else
#define SLOCK_DEBUGGER() /* nothing */
@ -866,8 +870,10 @@ _simple_lock(__volatile struct simplelock *alp, const char *id, int l)
alp->lock_data = __SIMPLELOCK_LOCKED;
#endif /* } */
KASSERT(alp->lock_holder == LK_NOCPU);
if (alp->lock_holder != LK_NOCPU) {
SLOCK_WHERE("simple_lock: uninitialized lock\n",
alp, id, l);
}
alp->lock_file = id;
alp->lock_line = l;
alp->lock_holder = cpu_id;