Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

VOP_GETATTR() needs a shared lock at least.

This commit is contained in:
hannken 2011-10-23 08:42:06 +00:00
parent d5f801e0ef
commit 113be15313
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/fs/smbfs/smbfs_kq.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: smbfs_kq.c,v 1.23 2011/06/12 03:35:54 rmind Exp $ */ /* $NetBSD: smbfs_kq.c,v 1.24 2011/10/23 08:42:06 hannken Exp $ */
/*- /*-
* Copyright (c) 2003, 2008 The NetBSD Foundation, Inc. * Copyright (c) 2003, 2008 The NetBSD Foundation, Inc.
@ -30,7 +30,7 @@
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: smbfs_kq.c,v 1.23 2011/06/12 03:35:54 rmind Exp $"); __KERNEL_RCSID(0, "$NetBSD: smbfs_kq.c,v 1.24 2011/10/23 08:42:06 hannken Exp $");
#include <sys/param.h> #include <sys/param.h>
#include <sys/systm.h> #include <sys/systm.h>
@ -149,7 +149,9 @@ smbfs_kqpoll(void *arg)
/* save v_size, smbfs_getattr() updates it */ /* save v_size, smbfs_getattr() updates it */
osize = ke->vp->v_size; osize = ke->vp->v_size;
vn_lock(ke->vp, LK_SHARED | LK_RETRY);
error = VOP_GETATTR(ke->vp, &attr, l->l_cred); error = VOP_GETATTR(ke->vp, &attr, l->l_cred);
VOP_UNLOCK(ke->vp);
if (error) { if (error) {
/* relock and proceed with next */ /* relock and proceed with next */
mutex_enter(&smbkq_lock); mutex_enter(&smbkq_lock);
@ -458,7 +460,9 @@ smbfs_kqfilter(void *v)
* held. This is likely cheap due to attrcache, so do it now. * held. This is likely cheap due to attrcache, so do it now.
*/ */
memset(&attr, 0, sizeof(attr)); memset(&attr, 0, sizeof(attr));
vn_lock(vp, LK_SHARED | LK_RETRY);
(void) VOP_GETATTR(vp, &attr, l->l_cred); (void) VOP_GETATTR(vp, &attr, l->l_cred);
VOP_UNLOCK(vp);
/* ensure the handler is running */ /* ensure the handler is running */
/* XXX this is unreliable. */ /* XXX this is unreliable. */