Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shutup one bogus -Wunitialized warning, and fix one correct 

XXX parrw() routine looks like not actually correct for transfers
XXX larger than sc_burst - someone with the hardware should check & fix this
This commit is contained in:
jdolecek 2003-11-01 12:53:33 +00:00
parent ca2d6f9331
commit 0ce8029b4c
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/arch/x68k/dev/par.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: par.c,v 1.20 2003/11/01 12:43:30 jdolecek Exp $ */
/* $NetBSD: par.c,v 1.21 2003/11/01 12:53:33 jdolecek Exp $ */
/*
* Copyright (c) 1982, 1990 The Regents of the University of California.
@ -36,7 +36,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: par.c,v 1.20 2003/11/01 12:43:30 jdolecek Exp $");
__KERNEL_RCSID(0, "$NetBSD: par.c,v 1.21 2003/11/01 12:53:33 jdolecek Exp $");
#include <sys/param.h>
#include <sys/errno.h>
@ -289,7 +289,8 @@ parrw(dev, uio)
{
int unit = UNIT(dev);
struct par_softc *sc = par_cd.cd_devs[unit];
int s, len, cnt;
int len=0xdeadbeef; /* XXX: shutup gcc */
int s, cnt=0;
char *cp;
int error = 0;
int buflen;
@ -395,6 +396,10 @@ parrw(dev, uio)
/*
* Adjust for those chars that we uiomove'ed but never wrote
*/
/*
* XXXjdolecek: this len usage is wrong, this will be incorrect
* if the transfer size is longer than sc_burst
*/
if (uio->uio_rw == UIO_WRITE && cnt != len) {
uio->uio_resid += (len - cnt);
#ifdef DEBUG