From 0ab1cb6dc141f5f3f5f61541a0457a2107124621 Mon Sep 17 00:00:00 2001 From: joerg Date: Wed, 24 Mar 2010 20:51:41 +0000 Subject: [PATCH] libfetch-2.31: PR 43013 by Brook Milligan: fetch(3) violates RFC 1738 for ftp:// URLs if the home directory is not the root directory. Remember the current directory the first time a CWD / CDUP has to be issued. Use the document as full URL if the URL started with two / (quoted or not), otherwise append it to the initial directory. --- external/bsd/fetch/dist/libfetch/common.c | 4 +- external/bsd/fetch/dist/libfetch/common.h | 4 +- external/bsd/fetch/dist/libfetch/ftp.c | 92 +++++++++++++++++------ 3 files changed, 75 insertions(+), 25 deletions(-) diff --git a/external/bsd/fetch/dist/libfetch/common.c b/external/bsd/fetch/dist/libfetch/common.c index 8608fee74c19..669b3001bf1d 100644 --- a/external/bsd/fetch/dist/libfetch/common.c +++ b/external/bsd/fetch/dist/libfetch/common.c @@ -1,4 +1,4 @@ -/* $NetBSD: common.c,v 1.1.1.8 2010/01/30 21:26:09 joerg Exp $ */ +/* $NetBSD: common.c,v 1.1.1.9 2010/03/24 20:51:41 joerg Exp $ */ /*- * Copyright (c) 1998-2004 Dag-Erling Coïdan Smørgrav * Copyright (c) 2008, 2010 Joerg Sonnenberger @@ -231,6 +231,7 @@ fetch_reopen(int sd) /* allocate and fill connection structure */ if ((conn = calloc(1, sizeof(*conn))) == NULL) return (NULL); + conn->ftp_home = NULL; conn->cache_url = NULL; conn->next_buf = NULL; conn->next_len = 0; @@ -711,6 +712,7 @@ fetch_close(conn_t *conn) ret = close(conn->sd); if (conn->cache_url) fetchFreeURL(conn->cache_url); + free(conn->ftp_home); free(conn->buf); free(conn); return (ret); diff --git a/external/bsd/fetch/dist/libfetch/common.h b/external/bsd/fetch/dist/libfetch/common.h index 84b0dec6b5ec..12f27861b92f 100644 --- a/external/bsd/fetch/dist/libfetch/common.h +++ b/external/bsd/fetch/dist/libfetch/common.h @@ -1,4 +1,4 @@ -/* $NetBSD: common.h,v 1.1.1.6 2010/01/30 21:26:09 joerg Exp $ */ +/* $NetBSD: common.h,v 1.1.1.7 2010/03/24 20:51:42 joerg Exp $ */ /*- * Copyright (c) 1998-2004 Dag-Erling Coïdan Smørgrav * All rights reserved. @@ -73,6 +73,8 @@ struct fetchconn { # endif #endif + char *ftp_home; + struct url *cache_url; int cache_af; int (*cache_close)(conn_t *); diff --git a/external/bsd/fetch/dist/libfetch/ftp.c b/external/bsd/fetch/dist/libfetch/ftp.c index 25802d2b7f7f..b93a5ae90cfc 100644 --- a/external/bsd/fetch/dist/libfetch/ftp.c +++ b/external/bsd/fetch/dist/libfetch/ftp.c @@ -1,4 +1,4 @@ -/* $NetBSD: ftp.c,v 1.1.1.10 2010/01/30 21:26:13 joerg Exp $ */ +/* $NetBSD: ftp.c,v 1.1.1.11 2010/03/24 20:51:44 joerg Exp $ */ /*- * Copyright (c) 1998-2004 Dag-Erling Coïdan Smørgrav * Copyright (c) 2008, 2009, 2010 Joerg Sonnenberger @@ -252,7 +252,7 @@ ftp_filename(const char *file, int *len, int *type, int subdir) * command. */ static int -ftp_pwd(conn_t *conn, char *pwd, size_t pwdlen) +ftp_pwd(conn_t *conn, char **pwd) { char *src, *dst, *end; int q; @@ -264,7 +264,10 @@ ftp_pwd(conn_t *conn, char *pwd, size_t pwdlen) src = conn->buf + 4; if (src >= end || *src++ != '"') return (FTP_PROTOCOL_ERROR); - for (q = 0, dst = pwd; src < end && pwdlen--; ++src) { + *pwd = malloc(end - src + 1); + if (*pwd == NULL) + return (FTP_PROTOCOL_ERROR); + for (q = 0, dst = *pwd; src < end; ++src) { if (!q && *src == '"') q = 1; else if (q && *src != '"') @@ -274,9 +277,12 @@ ftp_pwd(conn_t *conn, char *pwd, size_t pwdlen) else *dst++ = *src; } - if (!pwdlen) - return (FTP_PROTOCOL_ERROR); *dst = '\0'; + if (**pwd != '/') { + free(*pwd); + *pwd = NULL; + return (FTP_PROTOCOL_ERROR); + } return (FTP_OK); } @@ -285,69 +291,109 @@ ftp_pwd(conn_t *conn, char *pwd, size_t pwdlen) * file. */ static int -ftp_cwd(conn_t *conn, const char *file, int subdir) +ftp_cwd(conn_t *conn, const char *path, int subdir) { const char *beg, *end; - char pwd[PATH_MAX]; + char *pwd, *dst; int e, i, len; - /* If no slashes in name, no need to change dirs. */ - if (subdir) - end = file + strlen(file); - else if ((end = strrchr(file, '/')) == NULL) - return (0); + if (*path != '/') { + ftp_seterr(501); + return (-1); + } + ++path; + + /* Simple case: still in the home directory and no directory change. */ + if (conn->ftp_home == NULL && strchr(path, '/') == NULL && + (!subdir || *path == '\0')) + return 0; + if ((e = ftp_cmd(conn, "PWD\r\n")) != FTP_WORKING_DIRECTORY || - (e = ftp_pwd(conn, pwd, sizeof(pwd))) != FTP_OK) { + (e = ftp_pwd(conn, &pwd)) != FTP_OK) { ftp_seterr(e); return (-1); } + if (conn->ftp_home == NULL && (conn->ftp_home = strdup(pwd)) == NULL) { + fetch_syserr(); + free(pwd); + return (-1); + } + if (*path == '/') { + while (path[1] == '/') + ++path; + dst = strdup(path); + } else if (strcmp(conn->ftp_home, "/") == 0) { + dst = strdup(path - 1); + } else { + asprintf(&dst, "%s/%s", conn->ftp_home, path); + } + if (dst == NULL) { + fetch_syserr(); + free(pwd); + return (-1); + } + + if (subdir) + end = dst + strlen(dst); + else + end = strrchr(dst, '/'); + for (;;) { len = strlen(pwd); /* Look for a common prefix between PWD and dir to fetch. */ - for (i = 0; i <= len && i <= end - file; ++i) - if (pwd[i] != file[i]) + for (i = 0; i <= len && i <= end - dst; ++i) + if (pwd[i] != dst[i]) break; /* Keep going up a dir until we have a matching prefix. */ if (strcmp(pwd, "/") == 0) break; - if (pwd[i] == '\0' && (file[i - 1] == '/' || file[i] == '/')) + if (pwd[i] == '\0' && (dst[i - 1] == '/' || dst[i] == '/')) break; + free(pwd); if ((e = ftp_cmd(conn, "CDUP\r\n")) != FTP_FILE_ACTION_OK || (e = ftp_cmd(conn, "PWD\r\n")) != FTP_WORKING_DIRECTORY || - (e = ftp_pwd(conn, pwd, sizeof(pwd))) != FTP_OK) { + (e = ftp_pwd(conn, &pwd)) != FTP_OK) { ftp_seterr(e); + free(dst); return (-1); } } + free(pwd); #ifdef FTP_COMBINE_CWDS /* Skip leading slashes, even "////". */ - for (beg = file + i; beg < end && *beg == '/'; ++beg, ++i) + for (beg = dst + i; beg < end && *beg == '/'; ++beg, ++i) /* nothing */ ; /* If there is no trailing dir, we're already there. */ - if (beg >= end) + if (beg >= end) { + free(dst); return (0); + } /* Change to the directory all in one chunk (e.g., foo/bar/baz). */ e = ftp_cmd(conn, "CWD %.*s\r\n", (int)(end - beg), beg); - if (e == FTP_FILE_ACTION_OK) + if (e == FTP_FILE_ACTION_OK) { + free(dst); return (0); + } #endif /* FTP_COMBINE_CWDS */ /* That didn't work so go back to legacy behavior (multiple CWDs). */ - for (beg = file + i; beg < end; beg = file + i + 1) { + for (beg = dst + i; beg < end; beg = dst + i + 1) { while (*beg == '/') ++beg, ++i; - for (++i; file + i < end && file[i] != '/'; ++i) + for (++i; dst + i < end && dst[i] != '/'; ++i) /* nothing */ ; - e = ftp_cmd(conn, "CWD %.*s\r\n", file + i - beg, beg); + e = ftp_cmd(conn, "CWD %.*s\r\n", dst + i - beg, beg); if (e != FTP_FILE_ACTION_OK) { + free(dst); ftp_seterr(e); return (-1); } } + free(dst); return (0); }