Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity CID 2551: Don't use LIST_FOREACH() if you are going to free the

Browse Source 
current element (bp) in the body of the loop; the foreach does bp = bp->next;
This commit is contained in:
christos 2006-03-20 01:20:55 +00:00
parent db7722d2a7
commit 0794bfc81d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sbin/fsck_lfs/vnode.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: vnode.c,v 1.4 2006/03/17 15:53:46 rumble Exp $ */ /* $NetBSD: vnode.c,v 1.5 2006/03/20 01:20:55 christos Exp $ */
/*- /*-
* Copyright (c) 2003 The NetBSD Foundation, Inc. * Copyright (c) 2003 The NetBSD Foundation, Inc.
* All rights reserved. * All rights reserved.
@ -137,11 +137,13 @@ vnode_destroy(struct uvnode *tossvp)
--nvnodes; --nvnodes;
LIST_REMOVE(tossvp, v_getvnodes); LIST_REMOVE(tossvp, v_getvnodes);
LIST_REMOVE(tossvp, v_mntvnodes); LIST_REMOVE(tossvp, v_mntvnodes);
LIST_FOREACH(bp, &tossvp->v_dirtyblkhd, b_vnbufs) { while ((bp = LIST_FIRST(&tossvp->v_dirtyblkhd)) != NULL) {
LIST_REMOVE(bp, b_vnbufs);
bremfree(bp); bremfree(bp);
buf_destroy(bp); buf_destroy(bp);
} }
LIST_FOREACH(bp, &tossvp->v_cleanblkhd, b_vnbufs) { while ((bp = LIST_FIRST(&tossvp->v_cleanblkhd)) != NULL) {
LIST_REMOVE(bp, b_vnbufs);
bremfree(bp); bremfree(bp);
buf_destroy(bp); buf_destroy(bp);
} }