Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
NetBSD/usr.bin/make/unit-tests/suff-main-several.exp

145 lines
4.3 KiB
Plaintext
Raw Normal View History

make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 8: .1.2 .1.3 .1.4:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.1.2 .1.3 .1.4:)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Setting main node to ".1.2"
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 9: : Making ${.TARGET} from ${.IMPSRC}.
Parsing line 14: next-main:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(next-main:)
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 15: : Making ${.TARGET}
Parsing line 19: .SUFFIXES: .1 .2 .3 .4
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES: .1 .2 .3 .4)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Adding suffix ".1"
Adding suffix ".2"
Setting main node from ".1.2" back to null
defining transformation from `.1' to `.2'
inserting ".1" (1) at end of list
inserting ".2" (2) at end of list
Setting main node to ".1.3"
Adding suffix ".3"
Setting main node from ".1.3" back to null
defining transformation from `.1' to `.3'
inserting ".1" (1) at end of list
inserting ".3" (3) at end of list
Setting main node to ".1.4"
Adding suffix ".4"
Setting main node from ".1.4" back to null
defining transformation from `.1' to `.4'
inserting ".1" (1) at end of list
inserting ".4" (4) at end of list
Setting main node to "next-main"
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 24: .SUFFIXES:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES:)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Clearing all suffixes
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 32: .SUFFIXES: .4 .3 .2 .1
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES: .4 .3 .2 .1)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Adding suffix ".4"
Adding suffix ".3"
Adding suffix ".2"
Adding suffix ".1"
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 33: .SUFFIXES:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES:)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Clearing all suffixes
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 34: .SUFFIXES: .1 .2 .3 .4
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES: .1 .2 .3 .4)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Adding suffix ".1"
Adding suffix ".2"
Adding suffix ".3"
Adding suffix ".4"
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 35: .SUFFIXES:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES:)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Clearing all suffixes
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 36: .SUFFIXES: .4 .3 .2 .1
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.SUFFIXES: .4 .3 .2 .1)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
Adding suffix ".4"
Adding suffix ".3"
Adding suffix ".2"
Adding suffix ".1"
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 38: suff-main-several.1:
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(suff-main-several.1:)
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 39: : Making ${.TARGET} out of nothing.
Parsing line 40: next-main: suff-main-several.{2,3,4}
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(next-main: suff-main-several.{2,3,4})
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
# LinkSource: added child next-main - suff-main-several.{2,3,4}
make: remove overengineered Enum_ValueToString For printing the status of a GNode, there was already made_name (now renamed to GNodeMade_Name), which prints user-friendly text instead of the bare enum constant names. To do this change confidently, I first had to demonstrate that the output really affects something other than just the word "UNMADE". There had not been a test for that case before, and the test immediately discovered a bug in the -dg2 and -dg3 options. This bug is one of the oldest in make, dating back to at least 1993.
2021-02-02 20:56:31 +03:00
# next-main, unmade, type OP_DEPENDS|OP_HAS_COMMANDS, flags none
# suff-main-several.{2,3,4}, unmade, type none, flags none
make: make debug logging a bit more human-friendly The previous log format "ParseReadLine (%d): '%s'" focused on the implementation, it was not immediately obvious to a casual reader that the number in parentheses was the line number. Additionally, having both a colon and quotes in a log message is uncommon. The quotes have been added in parse.c 1.127 from 2007-01-01. The new log format "Parsing line %d: %s" is meant to be easier readable by humans. The quotes are not needed since ParseReadLine always strips trailing whitespace, leaving no room for ambiguities. The other log messages follow common punctuation rules, which makes the beginning of the line equally unambiguous. Before var.c 1.911 from 2021-04-05, variable assignments were logged with the format "%s:%s = %s", without a space after the colon.
2021-12-28 18:48:59 +03:00
Parsing line 42: .MAKEFLAGS: -d0 -dg1
make: remove filler word 'Do' from function names for parsing No functional change, except for debug logging.
2021-04-04 13:13:09 +03:00
ParseDependency(.MAKEFLAGS: -d0 -dg1)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
#*** Input graph:
make: remove overengineered Enum_ValueToString For printing the status of a GNode, there was already made_name (now renamed to GNodeMade_Name), which prints user-friendly text instead of the bare enum constant names. To do this change confidently, I first had to demonstrate that the output really affects something other than just the word "UNMADE". There had not been a test for that case before, and the test immediately discovered a bug in the -dg2 and -dg3 options. This bug is one of the oldest in make, dating back to at least 1993.
2021-02-02 20:56:31 +03:00
# .1.2, unmade, type OP_TRANSFORM, flags none
# .1.3, unmade, type OP_TRANSFORM, flags none
# .1.4, unmade, type OP_TRANSFORM, flags none
# next-main, unmade, type OP_DEPENDS|OP_HAS_COMMANDS, flags none
# suff-main-several.1, unmade, type OP_DEPENDS|OP_HAS_COMMANDS, flags none
# suff-main-several.{2,3,4}, unmade, type none, flags none
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
#
# Files that are only sources:
# .1.2 [.1.2]
# .1.3 [.1.3]
# .1.4 [.1.4]
# suff-main-several.{2,3,4} [suff-main-several.{2,3,4}]
#*** Global Variables:
.ALLTARGETS = .1.2 .1.3 .1.4 next-main suff-main-several.1 suff-main-several.{2,3,4}
.CURDIR = <curdir>
make: avoid trailing whitespace in debug log for variables Since trailing whitespace is invisible, describe the variable value in words to make it visible.
2022-03-26 17:34:07 +03:00
.INCLUDES = # (empty)
.LIBS = # (empty)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.MAKE = <details omitted>
.MAKE.DEPENDFILE = <details omitted>
Add .MAKE.UID and .MAKE.GID
2020-11-25 03:50:44 +03:00
.MAKE.GID = <details omitted>
Add .MAKE.JOBS.C to indicate wether -jC is supported
2023-09-09 19:41:04 +03:00
.MAKE.JOBS.C = <details omitted>
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.MAKE.LEVEL = <details omitted>
make: all command line overrides go in .MAKEOVERRIDES Not all variables that start with '.' are internals, and unless they are explicitly flagged as internal should go into .MAKEOVERRIDES Update varname-dot-makeoverrides to check this. Also avoid using SCOPE_CMDLINE when ReadOnly will do.
2024-05-07 21:26:22 +03:00
.MAKE.LEVEL.ENV = MAKELEVEL
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.MAKE.MAKEFILES = <details omitted>
.MAKE.MAKEFILE_PREFERENCE = <details omitted>
.MAKE.OS = <details omitted>
.MAKE.PATH_FILEMON = <details omitted>
.MAKE.PID = <details omitted>
.MAKE.PPID = <details omitted>
Add .MAKE.UID and .MAKE.GID
2020-11-25 03:50:44 +03:00
.MAKE.UID = <details omitted>
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.MAKEFLAGS = -r -k -d mps -d 0 -d g1
make: avoid trailing whitespace in debug log for variables Since trailing whitespace is invisible, describe the variable value in words to make it visible.
2022-03-26 17:34:07 +03:00
.MAKEOVERRIDES = # (empty)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.OBJDIR = <curdir>
.PATH = . <curdir>
make: avoid trailing whitespace in debug log for variables Since trailing whitespace is invisible, describe the variable value in words to make it visible.
2022-03-26 17:34:07 +03:00
.TARGETS = # (empty)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
.newline =
make: avoid trailing whitespace in debug log for variables Since trailing whitespace is invisible, describe the variable value in words to make it visible.
2022-03-26 17:34:07 +03:00
# (ends with space)
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
MACHINE = <details omitted>
MACHINE_ARCH = <details omitted>
MAKE = <details omitted>
MFLAGS = -r -k -d mps -d 0 -d g1
#*** Command-line Variables:
make(1): use fixed format for debug output of the directory cache The previous output format had a %-20s conversion specifier. This produced different output depending on the length of the pathname, which was too difficult to normalize. By moving the directory name to the end, it is no longer necessary to fill up any space, and the numbers are always aligned properly. As a result, 3 of the unit tests no longer need any special postprocessing of their output.
2020-12-04 17:28:50 +03:00
#*** Directory Cache:
# Stats: 0 hits 2 misses 0 near misses 0 losers (0%)
# refs hits directory
# 1 0 <curdir>
# 1 0 .
make: .SYSPATH: to add dirs to sysIncPath .SYSPATH: with no sources will clear sysIncPath otherwise sources are added Reviewed by: rillig
2023-01-24 03:24:02 +03:00
# 2 0 <defsyspath>
make(1): use fixed format for debug output of the directory cache The previous output format had a %-20s conversion specifier. This produced different output depending on the length of the pathname, which was too difficult to normalize. By moving the directory name to the end, it is no longer necessary to fill up any space, and the numbers are always aligned properly. As a result, 3 of the unit tests no longer need any special postprocessing of their output.
2020-12-04 17:28:50 +03:00
make(1): add another unit test for suffix handling
2020-11-22 23:36:17 +03:00
#*** Suffixes:
# ".4" (num 1, ref 1)
# To:
# From:
# Search Path:
# ".3" (num 2, ref 1)
# To:
# From:
# Search Path:
# ".2" (num 3, ref 1)
# To:
# From:
# Search Path:
# ".1" (num 4, ref 1)
# To:
# From:
# Search Path:
#*** Transformations:
make: don't know how to make suff-main-several.2 (continuing)
make: don't know how to make suff-main-several.3 (continuing)
make: don't know how to make suff-main-several.4 (continuing)
`next-main' not remade because of errors.
make(1): fix exit status in -k mode if a dependency fails Whether in -k mode or not, the exit status tells whether all requested targets were made or not. If a dependency could not be made, the main target was not made as well, therefore the exit status must be nonzero in such a case. This part of the code lacked proper unit tests until today. The unit test deptgt-end-fail.mk is compatible with make>=2003 at least, allowing to compare the output over time. In 2003, in the ok-ok-ok-ok case, "Making all from all-dep." was printed twice in a row, for whatever reason ... (40 minutes later) ... If I had just made the two commands for 'all' and '.END' more distinguishable. Back in 2003, the local variables for .END had not been initialized, instead the .END node was run with the local variables of the last preceding node. In this case, that node was 'all', therefore ${.TARGET} had obviously expanded to 'all'. Somewhere in 2004, the shell commands were no longer run with the -e flag, which resulted in the "exit status $?" line to be printed in cases that had stopped early before. Somewhere in 2005, the local variables for the .END node had been fixed. The variable ${.TARGET} now had the value '.END', just as expected. In addition, the dependencies for the .END node were made, although without getting their proper local variables. This resulted in the output "Making out of nothing" instead of the expected "Making end-dep out of nothing". Still in 2005, in the test case "all=ok all-dep=ok end=ok end-dep=ERR", the error code of the failed 'end-dep' was first reported as "*** Error code 1 (continuing)". To compensate for this improvement, a new bug had been introduced. The test case "all=ok all-dep=ok end=ERR end-dep=ERR" had properly exited with status 1 on 2005-01-01, but on 2006-01-01 it exited with status 0, thereby ignoring errors in the .END node. Somewhere in 2008, some of the error messages (but not all) were directed to stderr instead of stdout. The actual output stayed the same though. Somewhere in 2011, the dependency of the .END node got its own local variables, and ${.TARGET} now expanded to 'end-dep', as expected. Somewhere in 2016, the two empty lines between the "*** Error code 1 (continuing)" and the "Stop." got compressed into a single empty line. On 2020-12-07 (that is, today), the exit status 1 has been restored in the error cases, after it had been wrong for at least 14 years.
2020-12-07 03:53:30 +03:00
Stop.
make: stopped in unit-tests
exit status 1