make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
/* $NetBSD: compat.c,v 1.164 2020/10/05 19:24:29 rillig Exp $ */
|
1995-06-14 19:18:37 +04:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
|
2003-08-07 15:13:06 +04:00
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* This code is derived from software contributed to Berkeley by
|
|
|
|
* Adam de Boor.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
* 3. Neither the name of the University nor the names of its contributors
|
|
|
|
* may be used to endorse or promote products derived from this software
|
|
|
|
* without specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
|
|
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
|
|
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
|
|
* SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
1993-03-21 12:45:37 +03:00
|
|
|
* Copyright (c) 1988, 1989 by Adam de Boor
|
|
|
|
* Copyright (c) 1989 by Berkeley Softworks
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* This code is derived from software contributed to Berkeley by
|
|
|
|
* Adam de Boor.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
* 3. All advertising materials mentioning features or use of this software
|
|
|
|
* must display the following acknowledgement:
|
|
|
|
* This product includes software developed by the University of
|
|
|
|
* California, Berkeley and its contributors.
|
|
|
|
* 4. Neither the name of the University nor the names of its contributors
|
|
|
|
* may be used to endorse or promote products derived from this software
|
|
|
|
* without specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
|
|
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
|
|
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
|
|
* SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*-
|
|
|
|
* compat.c --
|
|
|
|
* The routines in this file implement the full-compatibility
|
|
|
|
* mode of PMake. Most of the special functionality of PMake
|
|
|
|
* is available in this mode. Things not supported:
|
|
|
|
* - different shells.
|
|
|
|
* - friendly variable substitution.
|
|
|
|
*
|
|
|
|
* Interface:
|
2020-09-28 00:35:16 +03:00
|
|
|
* Compat_Run Initialize things for this module and recreate
|
|
|
|
* thems as need creatin'
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
#include <sys/types.h>
|
|
|
|
#include <sys/stat.h>
|
|
|
|
#include <sys/wait.h>
|
2002-06-15 22:24:55 +04:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
#include <ctype.h>
|
|
|
|
#include <errno.h>
|
|
|
|
#include <signal.h>
|
|
|
|
#include <stdio.h>
|
2002-06-15 22:24:55 +04:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
#include "make.h"
|
|
|
|
#include "hash.h"
|
|
|
|
#include "dir.h"
|
|
|
|
#include "job.h"
|
|
|
|
#include "metachar.h"
|
|
|
|
#include "pathnames.h"
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2020-09-13 18:15:51 +03:00
|
|
|
/* "@(#)compat.c 8.2 (Berkeley) 3/19/94" */
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
MAKE_RCSID("$NetBSD: compat.c,v 1.164 2020/10/05 19:24:29 rillig Exp $");
|
1993-03-21 12:45:37 +03:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
static GNode *curTarg = NULL;
|
2017-07-20 22:29:54 +03:00
|
|
|
static pid_t compatChild;
|
|
|
|
static int compatSigno;
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2016-08-27 02:28:39 +03:00
|
|
|
/*
|
|
|
|
* CompatDeleteTarget -- delete a failed, interrupted, or otherwise
|
|
|
|
* duffed target if not inhibited by .PRECIOUS.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
CompatDeleteTarget(GNode *gn)
|
|
|
|
{
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if ((gn != NULL) && !Targ_Precious (gn)) {
|
|
|
|
char *p1;
|
|
|
|
const char *file = Var_Value(TARGET, gn, &p1);
|
2016-08-27 02:28:39 +03:00
|
|
|
|
|
|
|
if (!noExecute && eunlink(file) != -1) {
|
|
|
|
Error("*** %s removed", file);
|
|
|
|
}
|
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
bmake_free(p1);
|
2016-08-27 02:28:39 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-29 15:36:20 +03:00
|
|
|
/* Interrupt the creation of the current target and remove it if it ain't
|
|
|
|
* precious. Then exit.
|
1993-03-21 12:45:37 +03:00
|
|
|
*
|
2020-08-29 15:36:20 +03:00
|
|
|
* If .INTERRUPT exists, its commands are run first WITH INTERRUPTS IGNORED.
|
1993-03-21 12:45:37 +03:00
|
|
|
*
|
2016-08-27 02:28:39 +03:00
|
|
|
* XXX: is .PRECIOUS supposed to inhibit .INTERRUPT? I doubt it, but I've
|
|
|
|
* left the logic alone for now. - dholland 20160826
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
|
|
|
static void
|
2002-06-15 22:24:55 +04:00
|
|
|
CompatInterrupt(int signo)
|
1993-03-21 12:45:37 +03:00
|
|
|
{
|
|
|
|
GNode *gn;
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2016-08-27 02:28:39 +03:00
|
|
|
CompatDeleteTarget(curTarg);
|
1993-03-21 12:45:37 +03:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if ((curTarg != NULL) && !Targ_Precious (curTarg)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Run .INTERRUPT only if hit with interrupt signal
|
|
|
|
*/
|
|
|
|
if (signo == SIGINT) {
|
2020-09-26 19:00:12 +03:00
|
|
|
gn = Targ_FindNode(".INTERRUPT");
|
2008-12-13 18:19:29 +03:00
|
|
|
if (gn != NULL) {
|
2005-05-08 04:38:47 +04:00
|
|
|
Compat_Make(gn, gn);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2012-06-05 10:11:51 +04:00
|
|
|
if (signo == SIGQUIT)
|
|
|
|
_exit(signo);
|
2017-07-20 22:29:54 +03:00
|
|
|
/*
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
* If there is a child running, pass the signal on
|
|
|
|
* we will exist after it has exited.
|
2017-07-20 22:29:54 +03:00
|
|
|
*/
|
|
|
|
compatSigno = signo;
|
|
|
|
if (compatChild > 0) {
|
|
|
|
KILLPG(compatChild, signo);
|
|
|
|
} else {
|
|
|
|
bmake_signal(signo, SIG_DFL);
|
|
|
|
kill(myPid, signo);
|
|
|
|
}
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-08-22 11:01:34 +03:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
/*-
|
|
|
|
*-----------------------------------------------------------------------
|
|
|
|
* CompatRunCommand --
|
|
|
|
* Execute the next command for a target. If the command returns an
|
|
|
|
* error, the node's made field is set to ERROR and creation stops.
|
1993-03-21 12:45:37 +03:00
|
|
|
*
|
2002-06-15 22:24:55 +04:00
|
|
|
* Input:
|
|
|
|
* cmdp Command to execute
|
|
|
|
* gnp Node from which the command came
|
|
|
|
*
|
1993-03-21 12:45:37 +03:00
|
|
|
* Results:
|
|
|
|
* 0 if the command succeeded, 1 if an error occurred.
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
*
|
|
|
|
* Side Effects:
|
|
|
|
* The node's 'made' field may be set to ERROR.
|
|
|
|
*
|
|
|
|
*-----------------------------------------------------------------------
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
2004-05-07 12:12:15 +04:00
|
|
|
int
|
2020-09-27 14:37:19 +03:00
|
|
|
Compat_RunCommand(const char *cmdp, struct GNode *gn)
|
1993-03-21 12:45:37 +03:00
|
|
|
{
|
2020-09-28 00:35:16 +03:00
|
|
|
char *cmdStart; /* Start of expanded command */
|
|
|
|
char *bp;
|
|
|
|
Boolean silent; /* Don't print command */
|
|
|
|
Boolean doIt; /* Execute even if -n */
|
|
|
|
volatile Boolean errCheck; /* Check errors */
|
|
|
|
int reason; /* Reason for child's death */
|
|
|
|
int status; /* Description of child's death */
|
|
|
|
pid_t cpid; /* Child actually found */
|
|
|
|
pid_t retstat; /* Result of wait */
|
|
|
|
StringListNode *cmdNode; /* Node where current command is located */
|
|
|
|
const char **volatile av; /* Argument vector for thing to exec */
|
|
|
|
char **volatile mav; /* Copy of the argument vector for freeing */
|
|
|
|
Boolean useShell; /* TRUE if command should be executed
|
2006-10-10 00:46:33 +04:00
|
|
|
* using a shell */
|
2020-09-28 00:35:16 +03:00
|
|
|
const char *volatile cmd = cmdp;
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2020-08-29 11:09:07 +03:00
|
|
|
silent = (gn->type & OP_SILENT) != 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
errCheck = !(gn->type & OP_IGNORE);
|
2004-05-07 12:12:15 +04:00
|
|
|
doIt = FALSE;
|
2020-07-03 11:13:23 +03:00
|
|
|
|
2020-10-02 00:00:55 +03:00
|
|
|
/* Luckily the commands don't end up in a string pool, otherwise
|
|
|
|
* this comparison could match too early, in a dependency using "..."
|
|
|
|
* for delayed commands, run in parallel mode, using the same shell
|
|
|
|
* command line more than once; see JobPrintCommand.
|
|
|
|
* TODO: write a unit-test to protect against this potential bug. */
|
2020-08-30 14:12:05 +03:00
|
|
|
cmdNode = Lst_FindDatum(gn->commands, cmd);
|
2020-09-22 23:19:46 +03:00
|
|
|
(void)Var_Subst(cmd, gn, VARE_WANTRES, &cmdStart);
|
|
|
|
/* TODO: handle errors */
|
1993-03-21 12:45:37 +03:00
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
/*
|
|
|
|
* brk_string will return an argv with a NULL in av[0], thus causing
|
|
|
|
* execvp to choke and die horribly. Besides, how can we execute a null
|
|
|
|
* command? In any case, we warn the user that the command expanded to
|
|
|
|
* nothing (is this the right thing to do?).
|
|
|
|
*/
|
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
if (*cmdStart == '\0') {
|
1994-06-07 02:45:17 +04:00
|
|
|
free(cmdStart);
|
2020-07-03 11:02:55 +03:00
|
|
|
return 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2009-01-17 00:14:30 +03:00
|
|
|
cmd = cmdStart;
|
2020-08-28 07:48:56 +03:00
|
|
|
LstNode_Set(cmdNode, cmdStart);
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2020-09-23 06:06:38 +03:00
|
|
|
if (gn->type & OP_SAVE_CMDS) {
|
|
|
|
GNode *endNode = Targ_GetEndNode();
|
|
|
|
if (gn != endNode) {
|
|
|
|
Lst_Append(endNode->commands, cmdStart);
|
|
|
|
return 0;
|
|
|
|
}
|
2009-01-17 00:14:30 +03:00
|
|
|
}
|
|
|
|
if (strcmp(cmdStart, "...") == 0) {
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->type |= OP_SAVE_CMDS;
|
2020-07-03 11:02:55 +03:00
|
|
|
return 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
while ((*cmd == '@') || (*cmd == '-') || (*cmd == '+')) {
|
2004-05-07 12:12:15 +04:00
|
|
|
switch (*cmd) {
|
|
|
|
case '@':
|
2020-08-29 11:09:07 +03:00
|
|
|
silent = !DEBUG(LOUD);
|
2004-05-07 12:12:15 +04:00
|
|
|
break;
|
|
|
|
case '-':
|
1993-03-21 12:45:37 +03:00
|
|
|
errCheck = FALSE;
|
2004-05-07 12:12:15 +04:00
|
|
|
break;
|
|
|
|
case '+':
|
|
|
|
doIt = TRUE;
|
2015-06-17 20:43:23 +03:00
|
|
|
if (!shellName) /* we came here from jobs */
|
|
|
|
Shell_Init();
|
2004-05-07 12:12:15 +04:00
|
|
|
break;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
cmd++;
|
|
|
|
}
|
|
|
|
|
2020-09-11 20:32:36 +03:00
|
|
|
while (ch_isspace(*cmd))
|
1994-03-05 03:34:29 +03:00
|
|
|
cmd++;
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2012-05-31 01:42:04 +04:00
|
|
|
/*
|
|
|
|
* If we did not end up with a command, just skip it.
|
|
|
|
*/
|
|
|
|
if (!*cmd)
|
2020-07-03 11:02:55 +03:00
|
|
|
return 0;
|
2012-05-31 01:42:04 +04:00
|
|
|
|
2006-10-10 00:46:33 +04:00
|
|
|
#if !defined(MAKE_NATIVE)
|
|
|
|
/*
|
|
|
|
* In a non-native build, the host environment might be weird enough
|
|
|
|
* that it's necessary to go through a shell to get the correct
|
|
|
|
* behaviour. Or perhaps the shell has been replaced with something
|
|
|
|
* that does extra logging, and that should not be bypassed.
|
|
|
|
*/
|
|
|
|
useShell = TRUE;
|
|
|
|
#else
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Search for meta characters in the command. If there are no meta
|
|
|
|
* characters, there's no need to execute a shell to execute the
|
|
|
|
* command.
|
2015-06-19 11:03:35 +03:00
|
|
|
*
|
|
|
|
* Additionally variable assignments and empty commands
|
|
|
|
* go to the shell. Therefore treat '=' and ':' like shell
|
|
|
|
* meta characters as documented in make(1).
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
2020-07-03 11:13:23 +03:00
|
|
|
|
2015-06-19 17:32:04 +03:00
|
|
|
useShell = needshell(cmd, FALSE);
|
2006-10-10 00:46:33 +04:00
|
|
|
#endif
|
1993-03-21 12:45:37 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Print the command before echoing if we're not supposed to be quiet for
|
|
|
|
* this one. We also print the command if -n given.
|
|
|
|
*/
|
2001-01-01 18:47:37 +03:00
|
|
|
if (!silent || NoExecute(gn)) {
|
2005-07-26 02:55:58 +04:00
|
|
|
printf("%s\n", cmd);
|
1993-03-21 12:45:37 +03:00
|
|
|
fflush(stdout);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we're not supposed to execute any commands, this is as far as
|
|
|
|
* we go...
|
|
|
|
*/
|
2004-05-07 12:12:15 +04:00
|
|
|
if (!doIt && NoExecute(gn)) {
|
2020-07-03 11:02:55 +03:00
|
|
|
return 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-09-28 23:46:11 +03:00
|
|
|
DEBUG1(JOB, "Execute: '%s'\n", cmd);
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2006-10-10 00:46:33 +04:00
|
|
|
if (useShell) {
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
2006-10-10 00:46:33 +04:00
|
|
|
* We need to pass the command off to the shell, typically
|
|
|
|
* because the command contains a "meta" character.
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
2013-07-06 02:14:56 +04:00
|
|
|
static const char *shargv[5];
|
|
|
|
int shargc;
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2013-07-06 02:14:56 +04:00
|
|
|
shargc = 0;
|
|
|
|
shargv[shargc++] = shellPath;
|
2003-08-01 04:39:52 +04:00
|
|
|
/*
|
|
|
|
* The following work for any of the builtin shell specs.
|
|
|
|
*/
|
2013-09-02 23:26:42 +04:00
|
|
|
if (errCheck && shellErrFlag) {
|
2013-07-06 02:14:56 +04:00
|
|
|
shargv[shargc++] = shellErrFlag;
|
|
|
|
}
|
2001-06-02 00:33:37 +04:00
|
|
|
if (DEBUG(SHELL))
|
2013-07-06 02:14:56 +04:00
|
|
|
shargv[shargc++] = "-xc";
|
2001-06-02 00:33:37 +04:00
|
|
|
else
|
2013-07-06 02:14:56 +04:00
|
|
|
shargv[shargc++] = "-c";
|
|
|
|
shargv[shargc++] = cmd;
|
2020-08-30 22:56:02 +03:00
|
|
|
shargv[shargc] = NULL;
|
1993-03-21 12:45:37 +03:00
|
|
|
av = shargv;
|
1998-03-26 22:20:36 +03:00
|
|
|
bp = NULL;
|
2006-04-22 22:43:06 +04:00
|
|
|
mav = NULL;
|
1993-03-21 12:45:37 +03:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* No meta-characters, so no need to exec a shell. Break the command
|
|
|
|
* into words to form an argument vector we can execute.
|
|
|
|
*/
|
2020-08-30 23:08:47 +03:00
|
|
|
Words words = Str_Words(cmd, FALSE);
|
2020-08-30 22:56:02 +03:00
|
|
|
mav = words.words;
|
|
|
|
bp = words.freeIt;
|
2011-08-14 17:06:09 +04:00
|
|
|
av = (void *)mav;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
|
|
|
if (useMeta) {
|
|
|
|
meta_compat_start();
|
|
|
|
}
|
|
|
|
#endif
|
2020-07-03 11:13:23 +03:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Fork and execute the single command. If the fork fails, we abort.
|
|
|
|
*/
|
2017-07-20 22:29:54 +03:00
|
|
|
compatChild = cpid = vFork();
|
1993-03-21 12:45:37 +03:00
|
|
|
if (cpid < 0) {
|
|
|
|
Fatal("Could not fork");
|
|
|
|
}
|
|
|
|
if (cpid == 0) {
|
2007-10-05 19:27:45 +04:00
|
|
|
Var_ExportVars();
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
|
|
|
if (useMeta) {
|
|
|
|
meta_compat_child();
|
|
|
|
}
|
|
|
|
#endif
|
2020-08-22 13:07:29 +03:00
|
|
|
(void)execvp(av[0], (char *const *)UNCONST(av));
|
2002-03-14 19:08:37 +03:00
|
|
|
execError("exec", av[0]);
|
1997-12-31 09:06:12 +03:00
|
|
|
_exit(1);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2016-01-17 20:45:21 +03:00
|
|
|
|
|
|
|
free(mav);
|
|
|
|
free(bp);
|
|
|
|
|
2020-08-23 13:53:27 +03:00
|
|
|
/* XXX: Memory management looks suspicious here. */
|
|
|
|
/* XXX: Setting a list item to NULL is unexpected. */
|
2020-08-28 07:48:56 +03:00
|
|
|
LstNode_SetNull(cmdNode);
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
|
|
|
if (useMeta) {
|
2020-01-19 22:42:32 +03:00
|
|
|
meta_compat_parent(cpid);
|
2010-09-13 19:36:57 +04:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* The child is off and running. Now all we can do is wait...
|
|
|
|
*/
|
2020-09-13 09:36:54 +03:00
|
|
|
while ((retstat = wait(&reason)) != cpid) {
|
|
|
|
if (retstat > 0)
|
|
|
|
JobReapChild(retstat, reason, FALSE); /* not ours? */
|
|
|
|
if (retstat == -1 && errno != EINTR) {
|
|
|
|
break;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-09-13 09:36:54 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if (retstat < 0)
|
|
|
|
Fatal("error in wait: %d: %s", retstat, strerror(errno));
|
1996-11-06 20:58:58 +03:00
|
|
|
|
2020-09-13 09:36:54 +03:00
|
|
|
if (WIFSTOPPED(reason)) {
|
|
|
|
status = WSTOPSIG(reason); /* stopped */
|
|
|
|
} else if (WIFEXITED(reason)) {
|
|
|
|
status = WEXITSTATUS(reason); /* exited */
|
2019-12-19 10:14:07 +03:00
|
|
|
#if defined(USE_META) && defined(USE_FILEMON_ONCE)
|
2020-09-13 09:36:54 +03:00
|
|
|
if (useMeta) {
|
|
|
|
meta_cmd_finish(NULL);
|
|
|
|
}
|
2019-12-19 10:14:07 +03:00
|
|
|
#endif
|
2020-09-13 09:36:54 +03:00
|
|
|
if (status != 0) {
|
|
|
|
if (DEBUG(ERROR)) {
|
2020-09-27 14:37:19 +03:00
|
|
|
const char *cp;
|
2020-09-29 01:23:35 +03:00
|
|
|
debug_printf("\n*** Failed target: %s\n*** Failed command: ",
|
|
|
|
gn->name);
|
2020-09-13 09:36:54 +03:00
|
|
|
for (cp = cmd; *cp; ) {
|
|
|
|
if (ch_isspace(*cp)) {
|
2020-09-29 01:23:35 +03:00
|
|
|
debug_printf(" ");
|
2020-09-13 09:36:54 +03:00
|
|
|
while (ch_isspace(*cp))
|
|
|
|
cp++;
|
|
|
|
} else {
|
2020-09-29 01:23:35 +03:00
|
|
|
debug_printf("%c", *cp);
|
2020-09-13 09:36:54 +03:00
|
|
|
cp++;
|
2003-09-09 20:16:02 +04:00
|
|
|
}
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-09-29 01:23:35 +03:00
|
|
|
debug_printf("\n");
|
1996-11-06 20:58:58 +03:00
|
|
|
}
|
2020-09-13 09:36:54 +03:00
|
|
|
printf("*** Error code %d", status);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
status = WTERMSIG(reason); /* signaled */
|
|
|
|
printf("*** Signal %d", status);
|
|
|
|
}
|
1996-11-06 20:58:58 +03:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2020-09-13 09:36:54 +03:00
|
|
|
if (!WIFEXITED(reason) || (status != 0)) {
|
|
|
|
if (errCheck) {
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
2020-09-13 09:36:54 +03:00
|
|
|
if (useMeta) {
|
|
|
|
meta_job_error(NULL, gn, 0, status);
|
|
|
|
}
|
2010-09-13 19:36:57 +04:00
|
|
|
#endif
|
2020-09-13 09:36:54 +03:00
|
|
|
gn->made = ERROR;
|
|
|
|
if (keepgoing) {
|
|
|
|
/*
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
* Abort the current target, but let others
|
|
|
|
* continue.
|
2020-09-13 09:36:54 +03:00
|
|
|
*/
|
|
|
|
printf(" (continuing)\n");
|
|
|
|
} else {
|
|
|
|
printf("\n");
|
|
|
|
}
|
|
|
|
if (deleteOnError) {
|
|
|
|
CompatDeleteTarget(gn);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
} else {
|
2020-09-13 09:36:54 +03:00
|
|
|
/*
|
|
|
|
* Continue executing commands for this target.
|
|
|
|
* If we return 0, this will happen...
|
|
|
|
*/
|
|
|
|
printf(" (ignored)\n");
|
|
|
|
status = 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|
2020-09-13 09:36:54 +03:00
|
|
|
|
2003-09-09 03:54:54 +04:00
|
|
|
free(cmdStart);
|
2017-07-20 22:29:54 +03:00
|
|
|
compatChild = 0;
|
|
|
|
if (compatSigno) {
|
|
|
|
bmake_signal(compatSigno, SIG_DFL);
|
|
|
|
kill(myPid, compatSigno);
|
|
|
|
}
|
2020-07-03 11:13:23 +03:00
|
|
|
|
2020-07-03 11:02:55 +03:00
|
|
|
return status;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-08-22 11:01:34 +03:00
|
|
|
|
2020-09-27 14:43:46 +03:00
|
|
|
static void
|
|
|
|
RunCommands(GNode *gn)
|
2020-09-12 18:03:39 +03:00
|
|
|
{
|
2020-09-27 14:43:46 +03:00
|
|
|
StringListNode *ln;
|
|
|
|
for (ln = gn->commands->first; ln != NULL; ln = ln->next) {
|
|
|
|
const char *cmd = ln->datum;
|
|
|
|
if (Compat_RunCommand(cmd, gn) != 0)
|
|
|
|
break;
|
|
|
|
}
|
2020-09-12 18:03:39 +03:00
|
|
|
}
|
|
|
|
|
2020-09-26 19:41:42 +03:00
|
|
|
static void
|
|
|
|
MakeNodes(GNodeList *gnodes, GNode *pgn)
|
2020-09-12 18:10:55 +03:00
|
|
|
{
|
2020-09-27 14:39:02 +03:00
|
|
|
GNodeListNode *ln;
|
|
|
|
for (ln = gnodes->first; ln != NULL; ln = ln->next) {
|
|
|
|
GNode *cohort = ln->datum;
|
2020-09-26 19:41:42 +03:00
|
|
|
Compat_Make(cohort, pgn);
|
|
|
|
}
|
2020-09-12 18:10:55 +03:00
|
|
|
}
|
|
|
|
|
2020-09-26 19:41:42 +03:00
|
|
|
/* Make a target.
|
2002-06-15 22:24:55 +04:00
|
|
|
*
|
2020-09-26 19:41:42 +03:00
|
|
|
* If an error is detected and not being ignored, the process exits.
|
1993-03-21 12:45:37 +03:00
|
|
|
*
|
2020-09-26 19:41:42 +03:00
|
|
|
* Input:
|
|
|
|
* gn The node to make
|
|
|
|
* pgn Parent to abort if necessary
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
2020-09-26 19:41:42 +03:00
|
|
|
void
|
2020-09-12 18:10:55 +03:00
|
|
|
Compat_Make(GNode *gn, GNode *pgn)
|
1993-03-21 12:45:37 +03:00
|
|
|
{
|
2015-06-17 20:43:23 +03:00
|
|
|
if (!shellName) /* we came here from jobs */
|
|
|
|
Shell_Init();
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if (gn->made == UNMADE && (gn == pgn || (pgn->type & OP_MADE) == 0)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* First mark ourselves to be made, then apply whatever transformations
|
|
|
|
* the suffix module thinks are necessary. Once that's done, we can
|
|
|
|
* descend and make all our children. If any of them has an error
|
|
|
|
* but the -k flag was given, our 'make' field will be set FALSE again.
|
|
|
|
* This is our signal to not attempt to do anything but abort our
|
|
|
|
* parent as well.
|
|
|
|
*/
|
1998-11-11 22:37:06 +03:00
|
|
|
gn->flags |= REMAKE;
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->made = BEINGMADE;
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if ((gn->type & OP_MADE) == 0)
|
2005-02-16 18:11:52 +03:00
|
|
|
Suff_FindDeps(gn);
|
2020-09-26 19:41:42 +03:00
|
|
|
MakeNodes(gn->children, gn);
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if ((gn->flags & REMAKE) == 0) {
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->made = ABORTED;
|
2020-08-23 22:00:19 +03:00
|
|
|
pgn->flags &= ~(unsigned)REMAKE;
|
1999-09-16 04:49:48 +04:00
|
|
|
goto cohorts;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
|
2020-08-30 17:11:42 +03:00
|
|
|
if (Lst_FindDatum(gn->implicitParents, pgn) != NULL) {
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
char *p1;
|
|
|
|
Var_Set(IMPSRC, Var_Value(TARGET, gn, &p1), pgn);
|
|
|
|
bmake_free(p1);
|
2014-09-08 00:55:34 +04:00
|
|
|
}
|
1996-11-06 20:58:58 +03:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
2010-11-26 00:31:08 +03:00
|
|
|
* All the children were made ok. Now cmgn->mtime contains the
|
|
|
|
* modification time of the newest child, we need to find out if we
|
|
|
|
* exist and when we were modified last. The criteria for datedness
|
|
|
|
* are defined by the Make_OODate function.
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
2020-09-28 23:46:11 +03:00
|
|
|
DEBUG1(MAKE, "Examining %s...", gn->name);
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
if (! Make_OODate(gn)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->made = UPTODATE;
|
2020-09-28 23:46:11 +03:00
|
|
|
DEBUG0(MAKE, "up-to-date.\n");
|
1999-09-16 04:49:48 +04:00
|
|
|
goto cohorts;
|
2020-09-28 23:46:11 +03:00
|
|
|
} else
|
|
|
|
DEBUG0(MAKE, "out-of-date.\n");
|
1993-03-21 12:45:37 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the user is just seeing if something is out-of-date, exit now
|
|
|
|
* to tell him/her "yes".
|
|
|
|
*/
|
|
|
|
if (queryFlag) {
|
2005-07-26 02:55:58 +04:00
|
|
|
exit(1);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to be re-made. We also have to make sure we've got a $?
|
|
|
|
* variable. To be nice, we also define the $> variable using
|
|
|
|
* Make_DoAllVar().
|
|
|
|
*/
|
|
|
|
Make_DoAllVar(gn);
|
1996-11-06 20:58:58 +03:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Alter our type to tell if errors should be ignored or things
|
|
|
|
* should not be printed so CompatRunCommand knows what to do.
|
|
|
|
*/
|
2005-02-16 18:11:52 +03:00
|
|
|
if (Targ_Ignore(gn)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->type |= OP_IGNORE;
|
|
|
|
}
|
2005-02-16 18:11:52 +03:00
|
|
|
if (Targ_Silent(gn)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->type |= OP_SILENT;
|
|
|
|
}
|
|
|
|
|
2005-02-16 18:11:52 +03:00
|
|
|
if (Job_CheckCommands(gn, Fatal)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* Our commands are ok, but we still have to worry about the -t
|
|
|
|
* flag...
|
|
|
|
*/
|
1997-05-07 11:31:37 +04:00
|
|
|
if (!touchFlag || (gn->type & OP_MAKE)) {
|
1993-03-21 12:45:37 +03:00
|
|
|
curTarg = gn;
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
|
|
|
if (useMeta && !NoExecute(gn)) {
|
|
|
|
meta_job_start(NULL, gn);
|
|
|
|
}
|
|
|
|
#endif
|
2020-09-27 14:43:46 +03:00
|
|
|
RunCommands(gn);
|
2008-12-13 18:19:29 +03:00
|
|
|
curTarg = NULL;
|
1993-03-21 12:45:37 +03:00
|
|
|
} else {
|
2020-08-29 11:09:07 +03:00
|
|
|
Job_Touch(gn, (gn->type & OP_SILENT) != 0);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
gn->made = ERROR;
|
|
|
|
}
|
2010-09-13 19:36:57 +04:00
|
|
|
#ifdef USE_META
|
|
|
|
if (useMeta && !NoExecute(gn)) {
|
2016-05-12 23:28:34 +03:00
|
|
|
if (meta_job_finish(NULL) != 0)
|
|
|
|
gn->made = ERROR;
|
2010-09-13 19:36:57 +04:00
|
|
|
}
|
|
|
|
#endif
|
1993-03-21 12:45:37 +03:00
|
|
|
|
|
|
|
if (gn->made != ERROR) {
|
|
|
|
/*
|
|
|
|
* If the node was made successfully, mark it so, update
|
|
|
|
* its modification time and timestamp all its parents. Note
|
|
|
|
* that for .ZEROTIME targets, the timestamping isn't done.
|
|
|
|
* This is to keep its state from affecting that of its parent.
|
|
|
|
*/
|
|
|
|
gn->made = MADE;
|
1998-11-11 22:37:06 +03:00
|
|
|
pgn->flags |= Make_Recheck(gn) == 0 ? FORCE : 0;
|
1993-03-21 12:45:37 +03:00
|
|
|
if (!(gn->type & OP_EXEC)) {
|
1998-11-11 22:37:06 +03:00
|
|
|
pgn->flags |= CHILDMADE;
|
1993-03-21 12:45:37 +03:00
|
|
|
Make_TimeStamp(pgn, gn);
|
|
|
|
}
|
|
|
|
} else if (keepgoing) {
|
2020-08-23 22:00:19 +03:00
|
|
|
pgn->flags &= ~(unsigned)REMAKE;
|
1993-03-21 12:45:37 +03:00
|
|
|
} else {
|
2016-08-27 02:28:39 +03:00
|
|
|
PrintOnError(gn, "\nStop.");
|
2005-07-26 02:55:58 +04:00
|
|
|
exit(1);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
} else if (gn->made == ERROR) {
|
|
|
|
/*
|
|
|
|
* Already had an error when making this beastie. Tell the parent
|
|
|
|
* to abort.
|
|
|
|
*/
|
2020-08-23 22:00:19 +03:00
|
|
|
pgn->flags &= ~(unsigned)REMAKE;
|
1993-03-21 12:45:37 +03:00
|
|
|
} else {
|
2020-08-30 17:11:42 +03:00
|
|
|
if (Lst_FindDatum(gn->implicitParents, pgn) != NULL) {
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
char *p1;
|
|
|
|
const char *target = Var_Value(TARGET, gn, &p1);
|
2020-08-29 17:47:26 +03:00
|
|
|
Var_Set(IMPSRC, target != NULL ? target : "", pgn);
|
make(1): fix double-free bug in -DCLEANUP mode (since 2020-10-02)
The bug had been introduced with dir.c 1.155 on 2020-10-02 22:20:25. In
that commit, openDirectories was replaced with a combination of a list
with a hash table, for more efficient lookup by name.
Upon cleanup, OpenDirs_Done is called, which in turn called
Dir_ClearPath. Dir_ClearPath takes full ownership of the given list and
empties it. This was no problem before since afterwards the list was
empty and calling Lst_Free just frees the remaining list pointer.
With OpenDirs, this list was combined with a hash table, and the hash
table contains the list nodes, assuming that the OpenDirs functions have
full ownership of both the list and the hash table. This assumption was
generally correct, except for the one moment during cleanup where full
ownership of the list was passed to Dir_ClearPath, while the hash table
still contained pointers to the (now freed) list nodes. This by itself
was not a problem since the hash table would be freed afterwards. But
as part of Dir_ClearPath, OpenDirs_Remove was called, which looked up
the freed directory by name and now found the freed list node, trying to
free it again. Boom.
Fixed by replacing the call to Dir_ClearPath with code that only frees
the directories, without giving up control over the list.
2020-10-05 22:24:29 +03:00
|
|
|
bmake_free(p1);
|
2014-09-08 00:55:34 +04:00
|
|
|
}
|
1993-03-21 12:45:37 +03:00
|
|
|
switch(gn->made) {
|
|
|
|
case BEINGMADE:
|
2002-03-21 04:24:43 +03:00
|
|
|
Error("Graph cycles through %s", gn->name);
|
1993-03-21 12:45:37 +03:00
|
|
|
gn->made = ERROR;
|
2020-08-23 22:00:19 +03:00
|
|
|
pgn->flags &= ~(unsigned)REMAKE;
|
1993-03-21 12:45:37 +03:00
|
|
|
break;
|
|
|
|
case MADE:
|
|
|
|
if ((gn->type & OP_EXEC) == 0) {
|
1998-11-11 22:37:06 +03:00
|
|
|
pgn->flags |= CHILDMADE;
|
1993-03-21 12:45:37 +03:00
|
|
|
Make_TimeStamp(pgn, gn);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case UPTODATE:
|
|
|
|
if ((gn->type & OP_EXEC) == 0) {
|
|
|
|
Make_TimeStamp(pgn, gn);
|
|
|
|
}
|
|
|
|
break;
|
1994-03-05 03:34:29 +03:00
|
|
|
default:
|
|
|
|
break;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
1999-09-16 04:49:48 +04:00
|
|
|
cohorts:
|
2020-09-26 19:41:42 +03:00
|
|
|
MakeNodes(gn->cohorts, pgn);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2020-08-22 11:01:34 +03:00
|
|
|
|
2020-08-29 15:36:20 +03:00
|
|
|
/* Initialize this module and start making.
|
1993-03-21 12:45:37 +03:00
|
|
|
*
|
2002-06-15 22:24:55 +04:00
|
|
|
* Input:
|
2020-08-29 15:36:20 +03:00
|
|
|
* targs The target nodes to re-create
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
|
|
|
void
|
2020-09-22 07:05:41 +03:00
|
|
|
Compat_Run(GNodeList *targs)
|
1993-03-21 12:45:37 +03:00
|
|
|
{
|
2020-09-28 00:35:16 +03:00
|
|
|
GNode *gn = NULL; /* Current root target */
|
|
|
|
int errors; /* Number of targets not remade due to errors */
|
1993-03-21 12:45:37 +03:00
|
|
|
|
2015-06-17 20:43:23 +03:00
|
|
|
if (!shellName)
|
|
|
|
Shell_Init();
|
2003-08-01 04:39:52 +04:00
|
|
|
|
2010-06-03 19:40:15 +04:00
|
|
|
if (bmake_signal(SIGINT, SIG_IGN) != SIG_IGN) {
|
|
|
|
bmake_signal(SIGINT, CompatInterrupt);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2010-06-03 19:40:15 +04:00
|
|
|
if (bmake_signal(SIGTERM, SIG_IGN) != SIG_IGN) {
|
|
|
|
bmake_signal(SIGTERM, CompatInterrupt);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2010-06-03 19:40:15 +04:00
|
|
|
if (bmake_signal(SIGHUP, SIG_IGN) != SIG_IGN) {
|
|
|
|
bmake_signal(SIGHUP, CompatInterrupt);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
2010-06-03 19:40:15 +04:00
|
|
|
if (bmake_signal(SIGQUIT, SIG_IGN) != SIG_IGN) {
|
|
|
|
bmake_signal(SIGQUIT, CompatInterrupt);
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
|
2020-09-23 06:06:38 +03:00
|
|
|
/* Create the .END node now, to keep the (debug) output of the
|
|
|
|
* counter.mk test the same as before 2020-09-23. This implementation
|
|
|
|
* detail probably doesn't matter though. */
|
|
|
|
(void)Targ_GetEndNode();
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
|
|
|
* If the user has defined a .BEGIN target, execute the commands attached
|
|
|
|
* to it.
|
|
|
|
*/
|
|
|
|
if (!queryFlag) {
|
2020-09-26 19:00:12 +03:00
|
|
|
gn = Targ_FindNode(".BEGIN");
|
2008-12-13 18:19:29 +03:00
|
|
|
if (gn != NULL) {
|
2005-05-08 04:38:47 +04:00
|
|
|
Compat_Make(gn, gn);
|
2020-08-01 17:47:49 +03:00
|
|
|
if (gn->made == ERROR) {
|
|
|
|
PrintOnError(gn, "\nStop.");
|
|
|
|
exit(1);
|
|
|
|
}
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
1997-02-20 19:51:47 +03:00
|
|
|
/*
|
|
|
|
* Expand .USE nodes right now, because they can modify the structure
|
|
|
|
* of the tree.
|
|
|
|
*/
|
2006-11-18 01:07:39 +03:00
|
|
|
Make_ExpandUse(targs);
|
1997-02-20 19:51:47 +03:00
|
|
|
|
1993-03-21 12:45:37 +03:00
|
|
|
/*
|
2005-05-08 04:38:47 +04:00
|
|
|
* For each entry in the list of targets to create, call Compat_Make on
|
|
|
|
* it to create the thing. Compat_Make will leave the 'made' field of gn
|
1993-03-21 12:45:37 +03:00
|
|
|
* in one of several states:
|
2020-09-28 00:35:16 +03:00
|
|
|
* UPTODATE gn was already up-to-date
|
|
|
|
* MADE gn was recreated successfully
|
|
|
|
* ERROR An error occurred while gn was being created
|
|
|
|
* ABORTED gn was not remade because one of its inferiors
|
|
|
|
* could not be made due to errors.
|
1993-03-21 12:45:37 +03:00
|
|
|
*/
|
|
|
|
errors = 0;
|
2020-08-28 07:48:56 +03:00
|
|
|
while (!Lst_IsEmpty(targs)) {
|
|
|
|
gn = Lst_Dequeue(targs);
|
2005-05-08 04:38:47 +04:00
|
|
|
Compat_Make(gn, gn);
|
1993-03-21 12:45:37 +03:00
|
|
|
|
|
|
|
if (gn->made == UPTODATE) {
|
2005-07-26 02:55:58 +04:00
|
|
|
printf("`%s' is up to date.\n", gn->name);
|
1993-03-21 12:45:37 +03:00
|
|
|
} else if (gn->made == ABORTED) {
|
2005-07-26 02:55:58 +04:00
|
|
|
printf("`%s' not remade because of errors.\n", gn->name);
|
2020-09-29 02:13:57 +03:00
|
|
|
errors++;
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the user has defined a .END target, run its commands.
|
|
|
|
*/
|
|
|
|
if (errors == 0) {
|
2020-09-27 14:43:46 +03:00
|
|
|
GNode *endNode = Targ_GetEndNode();
|
2020-09-23 06:06:38 +03:00
|
|
|
Compat_Make(endNode, endNode);
|
|
|
|
/* XXX: Did you mean endNode->made instead of gn->made? */
|
2001-10-16 22:50:12 +04:00
|
|
|
if (gn->made == ERROR) {
|
2016-08-27 02:28:39 +03:00
|
|
|
PrintOnError(gn, "\nStop.");
|
2001-10-16 22:50:12 +04:00
|
|
|
exit(1);
|
|
|
|
}
|
1993-03-21 12:45:37 +03:00
|
|
|
}
|
|
|
|
}
|