NetBSD/sys/netbt/rfcomm_dlc.c

424 lines
11 KiB
C
Raw Normal View History

Rename min/max -> uimin/uimax for better honesty. These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended. HOWEVER! Some subsystems have #define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b)) even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation. To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it. I have left a handful of bootloaders that are too annoying to compile-test, and some dead code: cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4)) It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them. Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
2018-09-03 19:29:22 +03:00
/* $NetBSD: rfcomm_dlc.c,v 1.9 2018/09/03 16:29:36 riastradh Exp $ */
/*-
* Copyright (c) 2006 Itronix Inc.
* All rights reserved.
*
* Written by Iain Hibbert for Itronix Inc.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. The name of Itronix Inc. may not be used to endorse
* or promote products derived from this software without specific
* prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY ITRONIX INC. ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
* TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL ITRONIX INC. BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include <sys/cdefs.h>
Rename min/max -> uimin/uimax for better honesty. These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended. HOWEVER! Some subsystems have #define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b)) even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation. To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it. I have left a handful of bootloaders that are too annoying to compile-test, and some dead code: cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4)) It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them. Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
2018-09-03 19:29:22 +03:00
__KERNEL_RCSID(0, "$NetBSD: rfcomm_dlc.c,v 1.9 2018/09/03 16:29:36 riastradh Exp $");
#include <sys/param.h>
#include <sys/kernel.h>
#include <sys/mbuf.h>
#include <sys/proc.h>
#include <sys/socketvar.h>
#include <sys/systm.h>
#include <netbt/bluetooth.h>
#include <netbt/hci.h>
#include <netbt/l2cap.h>
#include <netbt/rfcomm.h>
/*
* rfcomm_dlc_lookup(rfcomm_session, dlci)
*
* Find DLC on session with matching dlci
*/
struct rfcomm_dlc *
rfcomm_dlc_lookup(struct rfcomm_session *rs, int dlci)
{
struct rfcomm_dlc *dlc;
LIST_FOREACH(dlc, &rs->rs_dlcs, rd_next) {
if (dlc->rd_dlci == dlci)
break;
}
return dlc;
}
/*
* rfcomm_dlc_newconn(rfcomm_session, dlci)
*
* handle a new dlc request (since its called from a couple of places)
*/
struct rfcomm_dlc *
rfcomm_dlc_newconn(struct rfcomm_session *rs, int dlci)
{
struct rfcomm_session *ls;
struct rfcomm_dlc *new, *dlc, *any, *best;
struct sockaddr_bt laddr, raddr, addr;
int chan;
/*
* Search amongst the listening DLC community for the best match for
* address & channel. We keep listening DLC's hanging on listening
* sessions in a last first order, so scan the entire bunch and keep
* a note of the best address and BDADDR_ANY matches in order to find
* the oldest and most specific match.
*/
* split PRU_PEERADDR and PRU_SOCKADDR function out of pr_generic() usrreq switches and put into separate functions xxx_{peer,sock}addr(struct socket *, struct mbuf *). - KASSERT(solocked(so)) always in new functions even if request is not implemented - KASSERT(pcb != NULL) and KASSERT(nam) if the request is implemented and not for tcp. * for tcp roll #ifdef KPROF and #ifdef DEBUG code from tcp_usrreq() into easier to cut & paste functions tcp_debug_capture() and tcp_debug_trace() - functions provided by rmind - remaining use of PRU_{PEER,SOCK}ADDR #define to be removed in a future commit. * rename netbt functions to permit consistency of pru function names (as has been done with other requests already split out). - l2cap_{peer,sock}addr() -> l2cap_{peer,sock}_addr_pcb() - rfcomm_{peer,sock}addr() -> rfcomm_{peer,sock}_addr_pcb() - sco_{peer,sock}addr() -> sco_{peer,sock}_addr_pcb() * split/refactor do_sys_getsockname(lwp, fd, which, nam) into two functions do_sys_get{peer,sock}name(fd, nam). - move PRU_PEERADDR handling into do_sys_getpeername() from do_sys_getsockname() - have svr4_stream directly call do_sys_get{sock,peer}name() respectively instead of providing `which' & fix a DPRINTF string that incorrectly wrote "getpeername" when it meant "getsockname" - fix sys_getpeername() and sys_getsockname() to call do_sys_get{sock,peer}name() without `which' and `lwp' & adjust comments - bump kernel version for removal of lwp & which parameters from do_sys_getsockname() note: future cleanup to remove struct mbuf * abuse in xxx_{peer,sock}name() still to come, not done in this commit since it is easier to do post split. patch reviewed by rmind welcome to 6.99.47
2014-07-09 08:54:03 +04:00
l2cap_sockaddr_pcb(rs->rs_l2cap, &laddr);
l2cap_peeraddr_pcb(rs->rs_l2cap, &raddr);
chan = RFCOMM_CHANNEL(dlci);
new = NULL;
any = best = NULL;
LIST_FOREACH(ls, &rfcomm_session_listen, rs_next) {
* split PRU_PEERADDR and PRU_SOCKADDR function out of pr_generic() usrreq switches and put into separate functions xxx_{peer,sock}addr(struct socket *, struct mbuf *). - KASSERT(solocked(so)) always in new functions even if request is not implemented - KASSERT(pcb != NULL) and KASSERT(nam) if the request is implemented and not for tcp. * for tcp roll #ifdef KPROF and #ifdef DEBUG code from tcp_usrreq() into easier to cut & paste functions tcp_debug_capture() and tcp_debug_trace() - functions provided by rmind - remaining use of PRU_{PEER,SOCK}ADDR #define to be removed in a future commit. * rename netbt functions to permit consistency of pru function names (as has been done with other requests already split out). - l2cap_{peer,sock}addr() -> l2cap_{peer,sock}_addr_pcb() - rfcomm_{peer,sock}addr() -> rfcomm_{peer,sock}_addr_pcb() - sco_{peer,sock}addr() -> sco_{peer,sock}_addr_pcb() * split/refactor do_sys_getsockname(lwp, fd, which, nam) into two functions do_sys_get{peer,sock}name(fd, nam). - move PRU_PEERADDR handling into do_sys_getpeername() from do_sys_getsockname() - have svr4_stream directly call do_sys_get{sock,peer}name() respectively instead of providing `which' & fix a DPRINTF string that incorrectly wrote "getpeername" when it meant "getsockname" - fix sys_getpeername() and sys_getsockname() to call do_sys_get{sock,peer}name() without `which' and `lwp' & adjust comments - bump kernel version for removal of lwp & which parameters from do_sys_getsockname() note: future cleanup to remove struct mbuf * abuse in xxx_{peer,sock}name() still to come, not done in this commit since it is easier to do post split. patch reviewed by rmind welcome to 6.99.47
2014-07-09 08:54:03 +04:00
l2cap_sockaddr_pcb(ls->rs_l2cap, &addr);
if (addr.bt_psm != laddr.bt_psm)
continue;
if (bdaddr_same(&laddr.bt_bdaddr, &addr.bt_bdaddr)) {
LIST_FOREACH(dlc, &ls->rs_dlcs, rd_next) {
if (dlc->rd_laddr.bt_channel == chan)
best = dlc;
}
}
if (bdaddr_any(&addr.bt_bdaddr)) {
LIST_FOREACH(dlc, &ls->rs_dlcs, rd_next) {
if (dlc->rd_laddr.bt_channel == chan)
any = dlc;
}
}
}
dlc = best ? best : any;
2007-03-15 22:47:50 +03:00
/* XXX
* Note that if this fails, we could have missed a chance to open
* a connection - really need to rewrite the strategy for storing
* listening DLC's so all can be checked in turn..
*/
if (dlc != NULL)
new = (*dlc->rd_proto->newconn)(dlc->rd_upper, &laddr, &raddr);
if (new == NULL) {
rfcomm_session_send_frame(rs, RFCOMM_FRAME_DM, dlci);
return NULL;
}
new->rd_dlci = dlci;
new->rd_mtu = rfcomm_mtu_default;
new->rd_mode = dlc->rd_mode;
memcpy(&new->rd_laddr, &laddr, sizeof(struct sockaddr_bt));
new->rd_laddr.bt_channel = chan;
memcpy(&new->rd_raddr, &raddr, sizeof(struct sockaddr_bt));
new->rd_raddr.bt_channel = chan;
new->rd_session = rs;
new->rd_state = RFCOMM_DLC_WAIT_CONNECT;
LIST_INSERT_HEAD(&rs->rs_dlcs, new, rd_next);
return new;
}
/*
* rfcomm_dlc_close(dlc, error)
*
* detach DLC from session and clean up
*/
void
rfcomm_dlc_close(struct rfcomm_dlc *dlc, int err)
{
struct rfcomm_session *rs;
struct rfcomm_credit *credit;
KASSERT(dlc->rd_state != RFCOMM_DLC_CLOSED);
/* Clear credit history */
rs = dlc->rd_session;
SIMPLEQ_FOREACH(credit, &rs->rs_credits, rc_next)
if (credit->rc_dlc == dlc)
credit->rc_dlc = NULL;
callout_stop(&dlc->rd_timeout);
LIST_REMOVE(dlc, rd_next);
dlc->rd_session = NULL;
dlc->rd_state = RFCOMM_DLC_CLOSED;
(*dlc->rd_proto->disconnected)(dlc->rd_upper, err);
/*
* It is the responsibility of the party who sends the last
* DISC(dlci) to disconnect the session, but we will schedule
* an expiry just in case that doesnt happen..
*/
if (LIST_EMPTY(&rs->rs_dlcs)) {
if (rs->rs_state == RFCOMM_SESSION_LISTEN)
rfcomm_session_free(rs);
else
callout_schedule(&rs->rs_timeout,
rfcomm_ack_timeout * hz);
}
}
/*
* rfcomm_dlc_timeout(dlc)
*
2011-08-21 18:20:34 +04:00
* DLC timeout function is scheduled when we sent any of SABM,
* DISC, MCC_MSC, or MCC_PN and should be cancelled when we get
* the relevant response. There is nothing to do but shut this
* DLC down.
*/
void
rfcomm_dlc_timeout(void *arg)
{
struct rfcomm_dlc *dlc = arg;
mutex_enter(bt_lock);
callout_ack(&dlc->rd_timeout);
if (dlc->rd_state != RFCOMM_DLC_CLOSED)
rfcomm_dlc_close(dlc, ETIMEDOUT);
else if (dlc->rd_flags & RFCOMM_DLC_DETACH) {
callout_destroy(&dlc->rd_timeout);
free(dlc, M_BLUETOOTH);
}
mutex_exit(bt_lock);
}
/*
* rfcomm_dlc_setmode(rfcomm_dlc)
*
* Set link mode for DLC. This is only called when the session is
* already open, so we don't need to worry about any previous mode
* settings.
*/
int
rfcomm_dlc_setmode(struct rfcomm_dlc *dlc)
{
struct sockopt sopt;
int mode = 0, err;
KASSERT(dlc->rd_session != NULL);
KASSERT(dlc->rd_session->rs_state == RFCOMM_SESSION_OPEN);
DPRINTF("dlci %d, auth %s, encrypt %s, secure %s\n", dlc->rd_dlci,
(dlc->rd_mode & RFCOMM_LM_AUTH ? "yes" : "no"),
(dlc->rd_mode & RFCOMM_LM_ENCRYPT ? "yes" : "no"),
(dlc->rd_mode & RFCOMM_LM_SECURE ? "yes" : "no"));
if (dlc->rd_mode & RFCOMM_LM_AUTH)
mode |= L2CAP_LM_AUTH;
if (dlc->rd_mode & RFCOMM_LM_ENCRYPT)
mode |= L2CAP_LM_ENCRYPT;
if (dlc->rd_mode & RFCOMM_LM_SECURE)
mode |= L2CAP_LM_SECURE;
sockopt_init(&sopt, BTPROTO_L2CAP, SO_L2CAP_LM, 0);
sockopt_setint(&sopt, mode);
err = l2cap_setopt(dlc->rd_session->rs_l2cap, &sopt);
sockopt_destroy(&sopt);
return err;
}
/*
* rfcomm_dlc_connect(rfcomm_dlc)
*
* initiate DLC connection (session is already connected)
*/
int
rfcomm_dlc_connect(struct rfcomm_dlc *dlc)
{
struct rfcomm_mcc_pn pn;
int err = 0;
KASSERT(dlc->rd_session != NULL);
KASSERT(dlc->rd_session->rs_state == RFCOMM_SESSION_OPEN);
KASSERT(dlc->rd_state == RFCOMM_DLC_WAIT_SESSION);
/*
* If we have not already sent a PN on the session, we must send
* a PN to negotiate Credit Flow Control, and this setting will
* apply to all future connections for this session. We ask for
* this every time, in order to establish initial credits.
*/
memset(&pn, 0, sizeof(pn));
pn.dlci = dlc->rd_dlci;
pn.priority = dlc->rd_dlci | 0x07;
pn.mtu = htole16(dlc->rd_mtu);
pn.flow_control = 0xf0;
dlc->rd_rxcred = (dlc->rd_rxsize / dlc->rd_mtu);
Rename min/max -> uimin/uimax for better honesty. These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended. HOWEVER! Some subsystems have #define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b)) even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation. To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it. I have left a handful of bootloaders that are too annoying to compile-test, and some dead code: cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4)) It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them. Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
2018-09-03 19:29:22 +03:00
dlc->rd_rxcred = uimin(dlc->rd_rxcred, RFCOMM_CREDITS_DEFAULT);
pn.credits = dlc->rd_rxcred;
err = rfcomm_session_send_mcc(dlc->rd_session, 1,
RFCOMM_MCC_PN, &pn, sizeof(pn));
if (err)
return err;
dlc->rd_state = RFCOMM_DLC_WAIT_CONNECT;
callout_schedule(&dlc->rd_timeout, rfcomm_mcc_timeout * hz);
return 0;
}
/*
* rfcomm_dlc_open(rfcomm_dlc)
*
* send "Modem Status Command" and mark DLC as open.
*/
int
rfcomm_dlc_open(struct rfcomm_dlc *dlc)
{
struct rfcomm_mcc_msc msc;
int err;
KASSERT(dlc->rd_session != NULL);
KASSERT(dlc->rd_session->rs_state == RFCOMM_SESSION_OPEN);
memset(&msc, 0, sizeof(msc));
msc.address = RFCOMM_MKADDRESS(1, dlc->rd_dlci);
msc.modem = dlc->rd_lmodem & 0xfe; /* EA = 0 */
msc.brk = 0x00 | 0x01; /* EA = 1 */
err = rfcomm_session_send_mcc(dlc->rd_session, 1,
RFCOMM_MCC_MSC, &msc, sizeof(msc));
if (err)
return err;
callout_schedule(&dlc->rd_timeout, rfcomm_mcc_timeout * hz);
dlc->rd_state = RFCOMM_DLC_OPEN;
(*dlc->rd_proto->connected)(dlc->rd_upper);
return 0;
}
/*
* rfcomm_dlc_start(rfcomm_dlc)
*
* Start sending data (and/or credits) for DLC. Our strategy is to
* send anything we can down to the l2cap layer. When credits run
* out, data will naturally bunch up. When not using credit flow
* control, we limit the number of packets we have pending to reduce
* flow control lag.
* We should deal with channel priority somehow.
*/
void
rfcomm_dlc_start(struct rfcomm_dlc *dlc)
{
struct rfcomm_session *rs = dlc->rd_session;
struct mbuf *m;
int len, credits;
KASSERT(rs != NULL);
KASSERT(rs->rs_state == RFCOMM_SESSION_OPEN);
KASSERT(dlc->rd_state == RFCOMM_DLC_OPEN);
for (;;) {
credits = 0;
len = dlc->rd_mtu;
if (rs->rs_flags & RFCOMM_SESSION_CFC) {
credits = (dlc->rd_rxsize / dlc->rd_mtu);
credits -= dlc->rd_rxcred;
Rename min/max -> uimin/uimax for better honesty. These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended. HOWEVER! Some subsystems have #define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b)) even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation. To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it. I have left a handful of bootloaders that are too annoying to compile-test, and some dead code: cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4)) It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them. Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
2018-09-03 19:29:22 +03:00
credits = uimin(credits, RFCOMM_CREDITS_MAX);
if (credits > 0)
len--;
if (dlc->rd_txcred == 0)
len = 0;
} else {
if (rs->rs_flags & RFCOMM_SESSION_RFC)
break;
if (dlc->rd_rmodem & RFCOMM_MSC_FC)
break;
if (dlc->rd_pending > RFCOMM_CREDITS_DEFAULT)
break;
}
if (dlc->rd_txbuf == NULL)
len = 0;
if (len == 0) {
if (credits == 0)
break;
/*
* No need to send small numbers of credits on their
* own unless the other end hasn't many left.
*/
if (credits < RFCOMM_CREDITS_DEFAULT
&& dlc->rd_rxcred > RFCOMM_CREDITS_DEFAULT)
break;
m = NULL;
} else {
/*
* take what data we can from (front of) txbuf
*/
m = dlc->rd_txbuf;
if (len < m->m_pkthdr.len) {
dlc->rd_txbuf = m_split(m, len, M_DONTWAIT);
if (dlc->rd_txbuf == NULL) {
dlc->rd_txbuf = m;
break;
}
} else {
dlc->rd_txbuf = NULL;
len = m->m_pkthdr.len;
}
}
DPRINTFN(10, "dlci %d send %d bytes, %d credits, rxcred = %d\n",
dlc->rd_dlci, len, credits, dlc->rd_rxcred);
if (rfcomm_session_send_uih(rs, dlc, credits, m)) {
printf("%s: lost %d bytes on DLCI %d\n",
__func__, len, dlc->rd_dlci);
break;
}
dlc->rd_pending++;
if (rs->rs_flags & RFCOMM_SESSION_CFC) {
if (len > 0)
dlc->rd_txcred--;
if (credits > 0)
dlc->rd_rxcred += credits;
}
}
}