Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
NetBSD/tests/usr.bin/xlint/lint1/msg_100.c

15 lines
286 B
C
Raw Normal View History

lint: add quotes around several placeholders in messages
2022-06-21 00:13:35 +03:00
/* $NetBSD: msg_100.c,v 1.6 2022/06/20 21:13:36 rillig Exp $ */
lint: add a test for each message produced by lint1 Having a test for each message ensures that upcoming refactorings don't break the basic functionality. Adding the tests will also discover previously unknown bugs in lint. The tests ensure that every lint message can actually be triggered, and they demonstrate how to do so. Having a separate file for each test leaves enough space for documenting historical anecdotes, rationale or edge cases, keeping them away from the source code. The interesting details of this commit are in Makefile and t_integration.sh. All other files are just auto-generated. When running the tests as part of ATF, they are packed together as a single test case. Conceptually, it would have been better to have each test as a separate test case, but ATF quickly becomes very slow as soon as a test program defines too many test cases, and 50 is already too many. The time complexity is O(n^2), not O(n) as one would expect. It's the same problem as in tests/usr.bin/make, which has over 300 test cases as well.
2021-01-02 13:22:42 +03:00
# 3 "msg_100.c"
lint: add quotes around several placeholders in messages
2022-06-21 00:13:35 +03:00
/* Test for message: unary '+' is illegal in traditional C [100] */
lint: add a test for each message produced by lint1 Having a test for each message ensures that upcoming refactorings don't break the basic functionality. Adding the tests will also discover previously unknown bugs in lint. The tests ensure that every lint message can actually be triggered, and they demonstrate how to do so. Having a separate file for each test leaves enough space for documenting historical anecdotes, rationale or edge cases, keeping them away from the source code. The interesting details of this commit are in Makefile and t_integration.sh. All other files are just auto-generated. When running the tests as part of ATF, they are packed together as a single test case. Conceptually, it would have been better to have each test as a separate test case, but ATF quickly becomes very slow as soon as a test program defines too many test cases, and 50 is already too many. The time complexity is O(n^2), not O(n) as one would expect. It's the same problem as in tests/usr.bin/make, which has over 300 test cases as well.
2021-01-02 13:22:42 +03:00
lint: model C language levels in a future-compatible way The options -t, -s and -S are confusing because they are used inconsistently. The option -S enables C99 features, but when using it instead of -s, it also doesn't enable all checks required by C90 and later. Prepare fixing of these inconsistencies by replacing the flag variables with language levels that can be extended in a straight-forward way as new C standards arrive. | option | allow_trad | allow_c90 | allow_c99 | allow_c11 | |--------|------------|-----------|-----------|-----------| | -t | x | - | - | - | | (none) | x | x | - | - | | -s | - | x | - | - | | -S | - | x | x | - | | -Ac11 | - | x | x | x | Each usage of the old flag variables will be inspected and migrated individually, to clean up the subtle variations in the conditions and to provide a simpler model. When lint was created in 1995, its focus was migrating traditional C code to C90 code. Lint does not help in migrating from C90 to C99 or from C99 to C11 since there are only few silent changes, and simply because nobody took the time to implement these migration aids. If necessary, such migration modes could be added separately. There is a small functional change: when the option -s is combined with either -S or -Ac11, lint now only keeps the last of these options. Previously, these options could be combined, leading to a mixture of language levels, halfway between C90, C99 and C11. Especially combining traditional C with C11 doesn't make sense, but xlint currently allows it. The 3 tests that accidentally specified multiple language levels have been adjusted to a single language level.
2022-04-16 16:25:27 +03:00
/* lint1-flags: -tw */
lint: add tests for several messages
2021-01-09 00:25:03 +03:00
int
tests/lint: replace 'expect' comments with 'expect+-' comments The 'expect+-' comments provide more context, which makes it easier to read the .c files on their own, without having to look up the actual diagnostics in the .exp files. Add tests for messages 105 and 106, which were about the obscure feature of some traditional C compilers that allowed the expression 'x->member' to access a struct member, even if 'x' had integer type. The remaining tests will be migrated in a future commit.
2022-06-15 23:18:31 +03:00
unary_plus(x)
int x;
{
lint: add quotes around several placeholders in messages
2022-06-21 00:13:35 +03:00
/* expect+1: warning: unary '+' is illegal in traditional C [100] */
tests/lint: replace 'expect' comments with 'expect+-' comments The 'expect+-' comments provide more context, which makes it easier to read the .c files on their own, without having to look up the actual diagnostics in the .exp files. Add tests for messages 105 and 106, which were about the obscure feature of some traditional C compilers that allowed the expression 'x->member' to access a struct member, even if 'x' had integer type. The remaining tests will be migrated in a future commit.
2022-06-15 23:18:31 +03:00
return +x;
lint: add tests for several messages
2021-01-09 00:25:03 +03:00
}