Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
NetBSD/tests/Makefile.inc

12 lines
419 B
PHP
Raw Normal View History

Fix sun2 build. Still there are some duplicate symbols in the rump libraries that make this awkward.
2020-05-17 21:52:43 +03:00
# $NetBSD: Makefile.inc,v 1.9 2020/05/17 18:52:43 christos Exp $
add Makefile.inc everywhere so that we can set WARNS=4 by default. Amazing how many bugs this found :-)
2010-11-03 19:10:19 +03:00
WARNS ?= 4
Do not care about dead functions for test cases, in this case it is often enough just noise.
2011-09-16 20:30:18 +04:00
CWARNFLAGS+= -Wno-missing-noreturn
better name
2017-01-14 04:33:32 +03:00
TOOLSSRCDIR:= ${.PARSEDIR}
CPPFLAGS+= -I${TOOLSSRCDIR}
PR/55102: Kamil Rytarowski: Duplicate fifo_vnodeop_entries, fifo_vnodeop_opv_desc symbols. Many filesystems ffs, lfs, ulfs, chfs, ext2fs etc. use fifofs internally for their fifo vnops. NFS does too, but it also needs networking anyway. Unfortunately fifofs brings in a lot of the networking code so that the rumpkernel is not well partition. In addition the fifo code is rarely used. The existing hack depended on duplicating the above symbols and adding minimal functionality for the majority of the the tests (except the ffs and the puffs one). In these two cases both symbols were loaded and the symbol sizes clashed which broke the sanitizers. While this can be fixed with weak symbols and other kinds of indirection, it is more straight forward to select between the minimal and the full fifofs implementation by introducing a new shared library librumpvfs_nofifofs.
2020-05-16 02:32:27 +03:00
.if ${RUMPFIFO:Uno} == "yes"
Fix sun2 build. Still there are some duplicate symbols in the rump libraries that make this awkward.
2020-05-17 21:52:43 +03:00
LIBRUMPFIFO_PRE = -lrumpvfs_fifofs -lrumpnet_local -lrumpnet_net -lrumpnet
PR/55102: Kamil Rytarowski: Duplicate fifo_vnodeop_entries, fifo_vnodeop_opv_desc symbols. Many filesystems ffs, lfs, ulfs, chfs, ext2fs etc. use fifofs internally for their fifo vnops. NFS does too, but it also needs networking anyway. Unfortunately fifofs brings in a lot of the networking code so that the rumpkernel is not well partition. In addition the fifo code is rarely used. The existing hack depended on duplicating the above symbols and adding minimal functionality for the majority of the the tests (except the ffs and the puffs one). In these two cases both symbols were loaded and the symbol sizes clashed which broke the sanitizers. While this can be fixed with weak symbols and other kinds of indirection, it is more straight forward to select between the minimal and the full fifofs implementation by introducing a new shared library librumpvfs_nofifofs.
2020-05-16 02:32:27 +03:00
.endif
Fix sun2 build. Still there are some duplicate symbols in the rump libraries that make this awkward.
2020-05-17 21:52:43 +03:00
LIBRUMPFIFO = -lrumpvfs_nofifofs
LIBRUMPBASE = ${LIBRUMPFIFO_PRE} -lrumpvfs -lrump -lrumpvfs -lrumpvfs_nofifofs -lrumpuser -lrump -lpthread
Centralize the base rump libraries into a variable used by all the other Makefiles so that we can make changes to it centrally as needed and have less mess. Fixes the sun2 build that needs rumpvfs after librump after the latest changes.
2020-03-01 21:08:12 +03:00